[Merge] ~3v1n0/ubuntu/+source/gnome-session:ubuntu/master-migrate-settings-to-yaru into ~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master
Marco Trevisan (Treviño)
mail at 3v1n0.net
Fri Aug 31 17:32:21 UTC 2018
Marco Trevisan (Treviño) has proposed merging ~3v1n0/ubuntu/+source/gnome-session:ubuntu/master-migrate-settings-to-yaru into ~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master.
Requested reviews:
Marco Trevisan (Treviño) (3v1n0)
Ubuntu Desktop (ubuntu-desktop)
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-session/+git/gnome-session/+merge/354136
Ensre we migrate Yaru relevant settings to defaults if the user values matches the old defaults.
However... This should actually only run when the ubuntu-session is running, or might change the settings to someone running the classic gnome-session but with the old ubuntu settings.
session migrations doesn't seem to help much on this, but there could be some strategies:
1) Return an error if the migration script runs in a session it doesn't care about
1a) change session-migrations to support a specific exit-code as "skip this" without triggering any error (or gprinterr)
2) Add this script to an XDG_DATA_DIR that is only specific for the ubuntu-session (needs more changes and is ugly)
So... Let me know what you prefer.
--
Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-session:ubuntu/master-migrate-settings-to-yaru into ~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2856 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-desktop/attachments/20180831/84c9558b/attachment.diff>
More information about the ubuntu-desktop
mailing list