[Oneiric-Topic] Reducing number of patches in our packages

[Javier Jardón]

On 7 April 2011 15:32, Rodrigo Moya <rodrigo.moya at canonical.com> wrote:
>
> About putting it in GTK, I don't know of all the appindicators patches,
> but most of the ones I've seen, more or less, are just a bunch of:
>
> #ifdef INDICATORS
> app_indicator_whatever...
> #else
> gtk_status_icon_whatever...
> #endif
>

Only FYI, currently GNOME is using libnotify for this (GtkStatusIcon
is "deprecated" in GNOME3 experience), so application developers
should write this if they want support all the possibilities:

#ifdef INDICATORS
  app_indicator_whatever...
#else
if server_has_persistence == false
  gtk_status_icon_whatever...
else
   notify_notification_new ...
#endif

Which is IMHO not good.
You have a complete example here: [1] and more info here [2]

> so I was talking about those. If there are other uses we would need to
> have, then why not push the stuff we need to GTK's GtkStatusIcon itself
> upstream? Then, we could just patch GTK to use the indicators when
> available, but apps would all use the same API (ie no need for us to
> write specific patches for each app)

Seems the correct approach for me.

[1] http://git.gnome.org/browse/libnotify/tree/tests/test-persistence.c
[2] http://live.gnome.org/GnomeShell/Design/Guidelines/MessageTray/Compatibility
-- 
Javier Jardón Cabezas