[Bug 130376] Re: crash while checking MD5sums on include list

[Colin Watson]

** Attachment added: "feisty-proposed patch"
   http://launchpadlibrarian.net/8695073/130376.feisty-proposed.patch

** Summary changed:

- crash while checking MD5sums on include list
+ crash while checking MD5sums on jigdo include list

** Changed in: cdrkit (Ubuntu Feisty)
   Importance: Undecided => High

** Changed in: cdrtools (Ubuntu Edgy)
   Importance: Undecided => High

** Changed in: cdrkit (Ubuntu Gutsy)
   Importance: Undecided => High

** Description changed:

  The build machine behind cdimage.ubuntu.com was recently upgraded to
  edgy/amd64. While testing the new system, I found that mkisofs
  segfaulted while trying to build Ubuntu alternate install CD images.
  Investigation showed that this is due to incorrect linked list code used
  while constructing the JTE include and exclude lists for jigdo file
  generation. This is unlikely to affect normal users of mkisofs, but
- affects those trying to build Debian or Ubuntu CD images.
+ affects those trying to build Debian or Ubuntu CD images. I would like
+ to propose this for a stable release update in order to fix Ubuntu's
+ production CD image building system without the need for a local build
+ of mkisofs.
  
  This is also Debian bug 411873, and I've sent a patch there to fix the
  linked list generation. I have applied this patch in cdrkit
  9:1.1.6-1ubuntu1 in gutsy. Corresponding patches against edgy and feisty
  are attached here.
  
  Since the crash is rather dependent on precise details of stack layout,
  it's not necessarily easy to reproduce directly. However, valgrind picks
  it up with no trouble. Steps to reproduce on an edgy system with mkisofs
  and valgrind installed (for feisty and gutsy, substitute "genisoimage"
  for "mkisofs" throughout:
  
    mkdir -p /tmp/mkisofs-test
    cd /tmp/mkisofs-test
    mkdir -p t/pool
    dd if=/dev/zero of=t/file bs=1024 count=100
    touch md5
    valgrind mkisofs -o t.iso -jigdo-jigdo t.jigdo -jigdo-template t.template -md5-list md5 -jigdo-force-md5 /pool/ t
  
  The output will contain an error similar to the following (exact numbers
  are unimportant):
  
    ==8624== Conditional jump or move depends on uninitialised value(s)
    ==8624==    at 0x42BB38: (within /usr/bin/mkisofs)
    ==8624==    by 0x40E7D6: (within /usr/bin/mkisofs)
    ==8624==    by 0x40EBD9: (within /usr/bin/mkisofs)
    ==8624==    by 0x40460E: main (in /usr/bin/mkisofs)
    ==8624==    by 0x4C570C3: (below main) (in /lib/libc-2.4.so)
  
  The patch affects only JTE code, so (barring regressions due simply to
  rebuilding cdrtools), other uses of mkisofs will not be affected.
  Typical uses of mkisofs to build simple ISO images from a tree of files
  on disk do not use JTE; it is an advanced feature for use by
  distributors of heavily-downloaded ISO images.

-- 
crash while checking MD5sums on jigdo include list
https://bugs.launchpad.net/bugs/130376
You received this bug notification because you are a member of Ubuntu
Burning Team, which is a bug contact for cdrkit in ubuntu.