firefox-lp-improvements

[Brian Murray]

On Mon, May 13, 2013 at 09:13:15AM -0700, Brian Murray wrote:
> On Mon, May 13, 2013 at 01:36:41AM -0700, Benjamin Kerensa wrote:
> > So as many of you are probably aware the firefox-lp-improvements
> > add-on has stopped working and I have talked to Brian Murray about it
> > and apparently we have hit a roadblock on trying to fix it. Is there
> > anyone who might be able to fix it on the mailing list? Perhaps
> > someone familiar with making Firefox Add-Ons.
> 
> To be clear, the whole add-on has not stopped working rather the
> functionality of reloading the standard responses and tags to add has
> stopped working.  Additionally, the greasemonkey scripts, of which the
> Firefox add-on is a compilation, continues to work.
> 
> > Here is the PPA https://launchpad.net/~gm-dev-launchpad/+archive/ppa
> > and source package
> > https://launchpad.net/~gm-dev-launchpad/+archive/ppa/+files/firefox-lp-improvements_0.99.93-0ubuntu1%7Eppa1.tar.gz
> 
> I looked at this a bit more just now and as I've already mentioned the
> issue is with loading the bug tags or standard responses.  (It is still
> possible to tag the bugs using the add-on.)  You can view the specific
> code that does this here:
> 
> http://bazaar.launchpad.net/~gm-dev-launchpad/launchpad-gm-scripts/master/view/head:/lp_buttontags.user.js#L76
> 
> Using the error console, accessible in the Tools menu under Web
> Developer,  in Firefox I see a message regarding 'syntax
> error' and 'undefined'.  That wasn't very helpful to me at least.

One other idea that occurred to me to fix this issue would be to stop
loading the standard replies and bug tags from xml files and putting
them back in the scripts themselves.  I looked at this briefly and if
someone were to work on this they would want to start with the tagging
script, lp_button_tags.user.js.  In rev 92 of launchpad-gm-scripts[1]
you can see how it used to work but I don't think it is as simple as
just using that version, I believe there were additional changes to the
tagging script since it was switched to loading the tags from an xml
file.

[1]
http://bazaar.launchpad.net/~gm-dev-launchpad/launchpad-gm-scripts/master/files/92

--
Brian Murray
Ubuntu Bug Master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/ubuntu-bugsquad/attachments/20130520/892a34ff/attachment.pgp>