[Bug 1738838] Re: Bluetooth icon shows "Off" and the only option given below it is "Turn Off"

Fri Jan 17 04:18:35 UTC 2020

Launchpad has imported 9 comments from the remote bug at
https://bugzilla.gnome.org/show_bug.cgi?id=789110.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2017-10-17T16:50:14+00:00 Mario Sánchez Prada wrote:

Created attachment 361759
Inconsistency in the bluetooth menu

In Endless's fork of GNOME Shell 3.24, we sometimes get an inconsistent
state in the system menu for the Bluetooth, that leads to weird
situations where you see the menu item as "Off" even if bluetooth is
active (and we know that because we can use the BT mouse), with a
submenu item showing "Turn Off".

See the attached picture for a better visual description of the problem.

As far as I can see, this is a problem in master too, patch will be
coming soon..

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/9

------------------------------------------------------------------------
On 2017-10-17T17:01:17+00:00 Mario Sánchez Prada wrote:

Created attachment 361760
1. bluetooth: Add missing 'BluetoothHardwareAirplaneMode' to D-Bus interface

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/10

------------------------------------------------------------------------
On 2017-10-17T17:01:34+00:00 Mario Sánchez Prada wrote:

Created attachment 361761
2. bluetooth: Be consistent when determining whether Bluetooth is off

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/11

------------------------------------------------------------------------
On 2017-10-17T17:13:36+00:00 Florian-muellner wrote:

Review of attachment 361760:

Whoops

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/12

------------------------------------------------------------------------
On 2017-10-17T17:39:40+00:00 Florian-muellner wrote:

Review of attachment 361761:

> otherwise we risk showing inconsistent states in each place if.

I'd be interested in how that sentence continues :-p

Joking aside, I don't think this is correct. As far as I can see,
"nConnectedDevices == -1" means there is no Bluetooth adapter that is
powered on - we can toggle the AirplaneMode property as much as we want
(that's what "Turn On/Off" does after all), that's not going to change.
So a better option may be to do

  this._toggleItem.actor.visible = nConnectedDevices > -1;

instead ...

::: js/ui/status/bluetooth.js
@@ +134,3 @@

+        // Bluetooth will be considered 'Off' if either the adapter
+        // is not available or it's set in irplane mode.

*airplane

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/13

------------------------------------------------------------------------
On 2017-10-17T19:20:09+00:00 Mario Sánchez Prada wrote:

Comment on attachment 361760
1. bluetooth: Add missing 'BluetoothHardwareAirplaneMode' to D-Bus interface

(In reply to Florian Müllner from comment #3)
> Review of attachment 361760 [details] [review]:
> 
> Whoops

Thanks for the review. Commmitted:
https://git.gnome.org/browse/gnome-shell/commit/?id=fb3070981c549ad9812d62f8ab868c323ed2ccf5

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/14

------------------------------------------------------------------------
On 2017-10-17T19:27:40+00:00 Mario Sánchez Prada wrote:

(In reply to Florian Müllner from comment #4)
> Review of attachment 361761 [details] [review]:
> 
> > otherwise we risk showing inconsistent states in each place if.
> 
> I'd be interested in how that sentence continues :-p

I'd be too, but I can't remember what I had in there :). I suppose it'
was something along the lines of "...if the adapter is available but
it's set in airplane mode".

> Joking aside, I don't think this is correct. As far as I can see,
> "nConnectedDevices == -1" means there is no Bluetooth adapter that is
> powered on - we can toggle the AirplaneMode property as much as we want
> (that's what "Turn On/Off" does after all), that's not going to change. So a
> better option may be to do
> 
>   this._toggleItem.actor.visible = nConnectedDevices > -1;
> 
> instead ...
> 
> ::: js/ui/status/bluetooth.js
> @@ +134,3 @@
>  
> +        // Bluetooth will be considered 'Off' if either the adapter
> +        // is not available or it's set in irplane mode.
> 
> *airplane

I thought the same thing, but I'm not 100% sure on whether it's possible
to have a BT adapter that would be "powered on"/"available" and would
still report to be in airplane mode (either soft or hard), so I thought
the sane thing to do was to check both things, just in case.

What looks more clear to me, is that the same condition should be used
in both places, since what you want to show in both labels depend on
exactly the same thing.

I'm adding Bastien to CC, since he added the original code and might
have extra info to decide what's best to do here.

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/15

------------------------------------------------------------------------
On 2018-11-21T20:10:32+00:00 Bugzilla-x wrote:

Was moved to https://gitlab.gnome.org/GNOME/gnome-
shell/merge_requests/118, closing.

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/37

------------------------------------------------------------------------
On 2020-01-17T03:47:59+00:00 Daniel van Vugt wrote:

Please reopen this bug. The above link is not a bug.

Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
shell/+bug/1738838/comments/39

-- 
You received this bug notification because you are a member of
Bluetooth, which is subscribed to gnome-bluetooth in Ubuntu.
https://bugs.launchpad.net/bugs/1738838

Title:
  Bluetooth icon shows "Off" and the only option given below it is "Turn
  Off"

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-bluetooth/+bug/1738838/+subscriptions