[Merge] lp:~kzapalowicz/bluez/autoenable-bt-adapters into lp:~bluetooth/bluez/ubuntu

Simon Fels simon.busch at canonical.com
Tue Jan 10 12:38:38 UTC 2017


Review: Needs Fixing



Diff comments:

> 
> === modified file 'debian/bluez.install'
> --- debian/bluez.install	2016-02-02 17:16:14 +0000
> +++ debian/bluez.install	2017-01-10 12:12:47 +0000
> @@ -25,7 +25,6 @@
>  lib/udev/hid2hci
>  lib/udev/rules.d/97-hid2hci.rules
>  attrib/gatttool usr/bin
> -debian/50-bluetooth-hci-auto-poweron.rules lib/udev/rules.d

I am not entirely sure but could be that this needs a maintainer script to get properly removed from existing installations. See https://code.launchpad.net/~morphis/aethercast/+git/aethercast/+merge/310189 for an example. But worth to check with somebody who knows more about deb packages than I do :-)

>  #-- for systemd
>  lib/systemd/system/bluetooth.service
>  etc/dbus-1/system.d/bluetooth.conf
> 
> === modified file 'debian/changelog'
> --- debian/changelog	2016-03-01 15:19:16 +0000
> +++ debian/changelog	2017-01-10 12:12:47 +0000
> @@ -1,3 +1,11 @@
> +bluez (5.37-0ubuntu6) UNRELEASED; urgency=medium
> +
> +  [Guilhem Lettron]

[Guilhem Lettron] -> [ Guilhem Lettron ]

> +  * Add debian/patches/use-autoenable-parameter-for-adapters.patch
> +    - Fix pairing with BLE when adapter is initialized by hcitool
> +
> + -- Konrad Zapałowicz <konrad.zapalowicz at canonical.com>  Tue, 10 Jan 2017 13:06:26 +0100
> +
>  bluez (5.37-0ubuntu5) xenial; urgency=medium
>  
>    [Tony Espy ]
> 
> === added file 'debian/patches/use-autoenable-parameter-for-adapters.patch'
> --- debian/patches/use-autoenable-parameter-for-adapters.patch	1970-01-01 00:00:00 +0000
> +++ debian/patches/use-autoenable-parameter-for-adapters.patch	2017-01-10 12:12:47 +0000
> @@ -0,0 +1,19 @@
> +Index: bluez/src/main.conf

This should have a proper patch header with author etc.

> +===================================================================
> +--- bluez.orig/src/main.conf
> ++++ bluez/src/main.conf
> +@@ -64,7 +64,7 @@
> + # 'false'.
> + #FastConnectable = false
> + 
> +-#[Policy]
> ++[Policy]
> + #
> + # The ReconnectUUIDs defines the set of remote services that should try
> + # to be reconnected to in case of a link loss (link supervision
> +@@ -86,4 +86,4 @@
> + # AutoEnable defines option to enable all controllers when they are found.
> + # This includes adapters present on start as well as adapters that are plugged
> + # in later on. Defaults to 'false'.
> +-#AutoEnable=false
> ++AutoEnable=true


-- 
https://code.launchpad.net/~kzapalowicz/bluez/autoenable-bt-adapters/+merge/314413
Your team Bluetooth is subscribed to branch lp:~bluetooth/bluez/ubuntu.



More information about the Ubuntu-bluetooth mailing list