[Merge] lp:~ssweeny/bluez/snappy-interface into lp:~bluetooth/bluez/snap-core-rolling

[Simon Fels]

Review: Needs Fixing

Left one naming related comment inline but otherwise LGTM

Diff comments:

> 
> === modified file 'snapcraft.yaml'
> --- snapcraft.yaml	2016-04-19 17:02:08 +0000
> +++ snapcraft.yaml	2016-04-19 17:02:08 +0000
> @@ -9,32 +9,24 @@
>  apps:
>    bluetoothctl:
>      command: usr/bin/bluetoothctl
> -    uses: [bluez-client]
> +    plugs: [bluez-client]

I would rather name the plugs/slots 'client' and 'service'. With that we get with a 'snap interfaces'

bluez:service
bluez:client

rather than

bluez:bluez-service
bluez:bluez-client

Leaving out 'bluez-' absolutely makes sense as we're now only naming the plug/slot inside the bluez snap and for nobody else. Auto connection will be made by decision stored in gadget/os snap and by interfaces used not the actual plug/slot names.

>    obexctl:
>      command: usr/bin/obexctl
> -    uses: [bluez-client]
> +    plugs: [bluez-client]
>    bluez:
>      command: "usr/lib/bluetooth/bluetoothd -E"
>      daemon: simple
> -    uses: [bluez-service]
> +    slots: [bluez-service]
>    obex:
>      command: "usr/lib/bluetooth/obexd"
>      daemon: simple
> -    uses: [obex-service]
> -uses:
> +    slots: [bluez-service]
> +plugs:
>    bluez-client:
> -    type: migration-skill
> -    caps: [bluez_client]
> +      interface: bluez
> +slots:
>    bluez-service:
> -    type: migration-skill
> -    security-policy:
> -      apparmor: bluez.apparmor
> -      seccomp: bluez.seccomp
> -  obex-service:
> -    type: migration-skill
> -    security-policy:
> -      apparmor: obex.apparmor
> -      seccomp: obex.seccomp
> +      interface: bluez
>  
>  parts:
>    bluez:


-- 
https://code.launchpad.net/~ssweeny/bluez/snappy-interface/+merge/292304
Your team Bluetooth is requested to review the proposed merge of lp:~ssweeny/bluez/snappy-interface into lp:~bluetooth/bluez/snap-core-rolling.