[Bug 179399] Re: bluetooth-properties crashed with signal 5 while adding HID device

[Robert Lange]

This bug affects me too.  I am using the latest hardy as of the
timestamp on this comment, and my bluetooth conf files have not been
altered manually.

I have a *small* amount of time I can devote to working on this bug.  I
have discovered the bug that causes the bluetooth-properties application
to crash.  However, while I can show how to avoid the crash, I do not
know how to fix the underlying problem yet.

This specific crash occurs because a call to dbus_g_proxy_end_call does
not check the return value or the error value of the function call, and
therefore propagates an uninitialized variable to a later dbus function
call.  I have attached a diff that can be applied to bluez-
gnome-0.25/properties/input.c to demonstrate that the error can be
trapped before the crash occurs.  However, right now I don't have time
to implement the proper error handling, so the code just prints a more
informative message, before continuing with the original, erroneous
control flow.

Someone more familiar with the project can hopefully explain why the
dbus call fails in the first place, and how to prevent it from failing.

Hopefully, this hint will allow someone to implement correct handling of
the dbus messaging system, so that these dbus errors are never
propagated to the user.

** Attachment added: "Diff demonstrating the checking of the return value of dbus_g_proxy_end_call in bluez-gnome-0.25/properties/input.c"
   http://launchpadlibrarian.net/14509147/bluez-gnome-0.25__properties__input.c.diff

-- 
bluetooth-properties crashed with signal 5 while adding HID device
https://bugs.launchpad.net/bugs/179399
You received this bug notification because you are a member of
Bluetooth, which is subscribed to bluez-gnome in ubuntu.