[Bug 2084776] Re: [needs-packaging] pwl-pc-services: Support for Palcom Wireless WWAN modules

[Michael Hudson-Doyle]

Chris and I reviewed this package as part of my AA training
today. Unfortunately we found a few more things to fix:

 1. In debian/copyright, can you please include a comment (as in
    https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#comment-field)
    to the Files: stanza for pwl-unlock/* to explain that the
    pwl_unlock binary does not have source.

 2. The packages install various files into /opt and there are lintian
    tags suppressing the warnings about this. Is it possible by
    patching the package to avoid this? It does seem that the
    pwl_unlock binary references paths in /opt so it may not be, but
    in that case can the comments next to the lintian overrides be
    expanded to make this more clear? Could we push back on the vendor
    to change these paths?

 3. There seems to be a lack of clarity about whether the GPL portions
    are strictly "GPL 2" or rather "GPL 2 or later". debian/copyright
    and the LICENSE file both say "GPL 2" but the file headers are all
    "or later".

    3a. This is in fact good because the GPL 2 is not considered to be
        compatible with the Apache license!

 4. There are some files where the license is not that indicated by
    debian/copyright:

     * pwl-fwupdate/fastboot is all BSD 2-Clause copyright AOSP)
     * pwl-unlock/fcc-unlock.d/413c is CC0 (this is not very interesting)

There are also some minor things we found which would not be
sufficient on a reject on their own but might as well be fixed:

 1. debian/source/include-binaries refers to a file
    debian/FwPackage.zip which does not exist. Can this be removed?

 2. All of packages override the custom-library-search-path lintian
    tag but it seems they don't need to. Can you remove these?

If these things can be fixed, these AAs at least would accept the
package.

-- 
You received this bug notification because you are a member of Ubuntu
Package Archive Administrators, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2084776

Title:
  [needs-packaging] pwl-pc-services: Support for Palcom Wireless WWAN
  modules

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/2084776/+subscriptions