[Merge] lp:~sil2100/ubuntu-archive-tools/sru-review-diffstat-py3 into lp:ubuntu-archive-tools

[Łukasz Zemczak]

Łukasz Zemczak has proposed merging lp:~sil2100/ubuntu-archive-tools/sru-review-diffstat-py3 into lp:ubuntu-archive-tools.

Commit message:
Switch sru-review to python3, by default attach diffstat output to the debdiff (with an option to disable that).

Requested reviews:
  Ubuntu Package Archive Administrators (ubuntu-archive)

For more details, see:
https://code.launchpad.net/~sil2100/ubuntu-archive-tools/sru-review-diffstat-py3/+merge/341667

Switch sru-review to python3, by default attach diffstat output to the debdiff (with an option to disable that).

The main change is the addition of diffstat output to the debdiff that's being analyzed - I noticed this can be useful for bigger packages in review.

This branch also, as mentioned, switches sru-review to python3. Besides the obvious reason of wanting to get rid of python2 in our tools, I wanted to use an ExitStack() context manager for proper handling of the temporary files which is only available in newer versions. It's much better than manually cleaning up files, less error prone and least likely to leave dangling temporary files on script crashes.
-- 
Your team Ubuntu Package Archive Administrators is requested to review the proposed merge of lp:~sil2100/ubuntu-archive-tools/sru-review-diffstat-py3 into lp:ubuntu-archive-tools.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4782 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20180319/84a84540/attachment-0001.diff>