[Merge] lp:~sil2100/ubuntu-archive-tools/sru-stop-using-v-d into lp:ubuntu-archive-tools

Brian Murray brian at ubuntu.com
Mon Jun 12 19:02:43 UTC 2017


Review: Needs Fixing

With Adam's change regarding v-failed-RELEASE a couple of other spots need changing.

Diff comments:

> === modified file 'sru-report'
> --- sru-report	2017-04-21 04:54:56 +0000
> +++ sru-report	2017-06-09 17:32:41 +0000
> @@ -336,8 +336,7 @@
>                      cls += 'kerneltracking '
>                  if 'verification-failed' in t:
>                      cls += ' verificationfailed'

This needs changing for verification-failed or verification-failed-$release.

> -                elif ('verification-done' in t or
> -                      'verification-done-%s' % release in t):
> +                elif 'verification-done-%s' % release in t:
>                      cls += ' verified'
>                      removable = False
>                  elif b in broken_bugs:
> 
> === modified file 'sru-review'
> --- sru-review	2017-04-27 20:32:35 +0000
> +++ sru-review	2017-06-09 17:32:41 +0000
> @@ -300,7 +300,8 @@
>  
>      if not sourcepkg or 'linux' not in sourcepkg:
>          btags = bug.tags
> -        for t in ('verification-failed', 'verification-done'):
> +        for t in ('verification-failed', 'verification-done', 
> +                  'verification-done-%s' % release):

I think this too should include 'v-failed-$release'.

>              if t in btags:
>                  # this dance is needed due to
>                  # https://bugs.launchpad.net/launchpadlib/+bug/254901


-- 
https://code.launchpad.net/~sil2100/ubuntu-archive-tools/sru-stop-using-v-d/+merge/325326
Your team Ubuntu Package Archive Administrators is requested to review the proposed merge of lp:~sil2100/ubuntu-archive-tools/sru-stop-using-v-d into lp:ubuntu-archive-tools.



More information about the ubuntu-archive mailing list