[Merge] lp:~sil2100/ubuntu-archive-tools/plus-sign-review into lp:ubuntu-archive-tools

[Łukasz Zemczak]

Łukasz Zemczak has proposed merging lp:~sil2100/ubuntu-archive-tools/plus-sign-review into lp:ubuntu-archive-tools.

Commit message:
Stop urlencoding source package name in sru-review when trying to access the debdiff as it makes it impossible to review packages with + in the name.

Requested reviews:
  Ubuntu Package Archive Administrators (ubuntu-archive)

For more details, see:
https://code.launchpad.net/~sil2100/ubuntu-archive-tools/plus-sign-review/+merge/328449

Do we really need to urlencode the source package name? In the current state it just makes the script not be able to access the debdiff, e.g.:
http://launchpadlibrarian.net/330880566/gtk+2.0_2.24.30-1ubuntu1.16.04.1_2.24.30-1ubuntu1.16.04.2.diff.gz

With quote() being used, the regexp cannot find the link in the queue webpage contents as the + sign is urlencoded. I wonder why this was added in the first place? Did something change in how links to the librarian are used?
-- 
Your team Ubuntu Package Archive Administrators is requested to review the proposed merge of lp:~sil2100/ubuntu-archive-tools/plus-sign-review into lp:ubuntu-archive-tools.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1212 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20170802/a931e945/attachment-0001.diff>