[Merge] lp:~laney/britney/autopkgtest-no-delay-if-never-passed into lp:~ubuntu-release/britney/britney2-ubuntu
Iain Lane
iain at orangesquash.org.uk
Tue Nov 17 11:15:08 UTC 2015
Diff comments:
> === modified file 'autopkgtest.py'
> --- autopkgtest.py 2015-11-17 08:15:31 +0000
> +++ autopkgtest.py 2015-11-17 11:07:07 +0000
> @@ -713,9 +719,12 @@
> (testsrc, testver, arch, trigger))
> continue
>
> - pkg_arch_result.setdefault((testsrc, testver), {})[arch] = result
> + pkg_arch_result.setdefault((testsrc, testver), {})[arch] = (result, passed)
>
> for ((testsrc, testver), arch_results) in pkg_arch_result.items():
> - r = arch_results.values()
> - passed = 'REGRESSION' not in r and 'RUNNING' not in r
I probably could instead do the "ever_passed" check here, not sure if that's cleaner.
pseudocode: passed = 'ALWAYSFAIL' in r or running_but_never_passed(testsrc, testver, arch_results)
> - yield (passed, testsrc, testver, arch_results)
> + # extract "passed"
> + ps = [p for (_, p) in arch_results.values()]
> + # and then strip them out - these aren't part of our API
> + arch_results = {arch: r for arch, (r, p) in arch_results.items()}
> + # we've passed if all results are True
> + yield (False not in ps, testsrc, testver, arch_results)
--
https://code.launchpad.net/~laney/britney/autopkgtest-no-delay-if-never-passed/+merge/277672
Your team Ubuntu Package Archive Administrators is requested to review the proposed merge of lp:~laney/britney/autopkgtest-no-delay-if-never-passed into lp:~ubuntu-release/britney/britney2-ubuntu.
More information about the ubuntu-archive
mailing list