Rejecting nova-compute-lxd
Martin Pitt
martin.pitt at ubuntu.com
Fri Feb 27 05:13:06 UTC 2015
Hey Chuck,
I reviewed nova-compute-lxd from the source NEW queue, and have to
reject it:
* debian/copyright is missing several copyrights, from HP, Citrix,
OpenStack Foundation, CloudScaling, and others. Also, a copyright
year 2015 from Canonical. Check grep -ri '(c)'
Hint: No need to repeat the same license several times, you can just
say "License: Apache-2" n times, and at the bottom have a "License:
Apache-2" block with the full text. (That's not a rejection issue,
of course)
* debian/control declares a python-nova.flex binary package which is
already in the archive (built by nova-compute-flex). But it
doesn't actually install any files into it, and it's also missing
${python:Depends}. Also, its XB-Python-Version: is wrong.
* debian/python-nova.lxd.install doesn't match any binary that this
source produces. Maybe the above should be renamed to
python-nova.lxd? nova-compute-lxd wants to depend on it, so
something should build that package.
* package descriptions talk about "Flex" -- copy&paste leftover?
* (not a rejection reason, but please clean up) Rename
debian/install to debian/<package>.install for packages which
produce multiple binaries.
* Please bump standards version to 3.9.6.
Will this supersede nova-compute-flex, or is that yet something
different?
Note that I subscribed ubuntu-release to the FFE bug #1424029 so that
they actually have a chance to see it.
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
More information about the ubuntu-archive
mailing list