reminders-app NEW review

[David Planella]

Thanks Didier for confirming. I'll look into migrating the package to 3.0
(quilt) then.

Colin, as per the license fixes, does this look ok to you, also given the
comments in the MP's description?

https://code.launchpad.net/~dpm/reminders-app/debian-copyright/+merge/225646

Cheers,
David.


On Fri, Jul 4, 2014 at 1:20 PM, Didier Roche <didier.roche at canonical.com>
wrote:

> Le 04/07/2014 12:16, Colin Watson a écrit :
>
>  On Fri, Jul 04, 2014 at 12:09:23PM +0200, David Planella wrote:
>>
>>>     On Fri, Jul 4, 2014 at 11:51 AM, Colin Watson <[1]
>>> cjwatson at ubuntu.com>
>>>     wrote:
>>>
>>>       You could avoid having to do the chmod in override_dh_install if
>>> you
>>>       converted the source package to the 3.0 (quilt) format; that would
>>> mean
>>>       that the executable bit would be preserved in the source package.
>>>
>>>     Indeed, I saw that and StevenK suggested the same, but then I was
>>> advised
>>>     to drop the debian/source folder as per the instructions in [2]. If
>>> this
>>>     is a better way and it is compatible with the CI train, then I'll be
>>> happy
>>>     to change the source to 3.0 (quilt).
>>>
>> The thrust of that advice seems to be to drop all quilt patches, and
>> then it's just dropping debian/source/ as a side-effect.  I think this
>> is probably slightly misguided - it's perfectly reasonable to use the
>> 3.0 (quilt) format even if you have no quilt patches, and as this shows
>> it can be useful to do so (another reason why it might be useful would
>> be if one needed to ship binary files under debian/).  You should check
>> with a CI train expert whether it's compatible, though.
>>
>> Thanks,
>>
>>  I confirm this is completely compatible. Some of the sources are using
> it. Not sure why this instruction is there as this was from early
> daily-release days, 2 years ago, but then, was fixed.
>
> Cheers,
> Didier
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20140704/1da1e15a/attachment.html>