reminders-app NEW review

[David Planella]

On Fri, Jul 4, 2014 at 11:51 AM, Colin Watson <cjwatson at ubuntu.com> wrote:

> I'm accepting reminders-app, but a couple of notes:
>
> reminders-app's debian/copyright file is incomplete: it fails to list
> the fairly large number of files that are under the Apache 2.0 licence.
> The licences are compatible, fortunately, but please regard this as a
> high-priority bug and make sure that this is fixed ASAP; we shouldn't
> have incomplete copyright files.
>
>
Thanks a lot Colin, I've filed the bug [1] and I'll look into fixing it
asap.


> You could avoid having to do the chmod in override_dh_install if you
> converted the source package to the 3.0 (quilt) format; that would mean
> that the executable bit would be preserved in the source package.
>

Indeed, I saw that and StevenK suggested the same, but then I was advised
to drop the debian/source folder as per the instructions in [2]. If this is
a better way and it is compatible with the CI train, then I'll be happy to
change the source to 3.0 (quilt).

Thanks!

Cheers,
David.

[1]: https://bugs.launchpad.net/reminders-app/+bug/1337783
[2]: https://wiki.ubuntu.com/DailyRelease/InlinePackaging
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20140704/34175a4a/attachment.html>