nvidia-persistenced maintainer script problems

[Colin Watson]

On Tue, May 28, 2013 at 03:06:42PM +0200, Alberto Milone wrote:
> Would these changes be enough?

> diff --git a/debian/postinst b/debian/postinst
> index fa1e1cb..bffb34b 100644
> --- a/debian/postinst
> +++ b/debian/postinst
> @@ -28,18 +28,8 @@ case "$1" in
>      configure)
>          if ! id $nvpd_user > /dev/null 2>&1; then
>              # Create the user and group
> -            useradd -s /sbin/nologin -d '/' \
> -            -c 'NVIDIA Persistence Daemon' -r "$nvpd_user"
> -        fi
> -
> -        job_status="$(initctl status "$upstart_service" 2>/dev/null | \
> -           grep "start" || true)"
> -
> -#        if ! initctl status "$upstart_service" | \
> -#           grep "start" > /dev/null 2>&1; then
> -         if [ ! -z "$job_status" ]; then
> -            # Start the daemon
> -            initctl start "$upstart_service"
> +            useradd --system --home '/' --shell '/sbin/nologin' \
> +            -c 'NVIDIA Persistence Daemon' "$nvpd_user"
>          fi
>      ;;
>  

adduser here, not useradd - you changed the arguments but not the
command name.

Otherwise this looks fine, assuming you've tested it :-)

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]