[Bug 1025720] Re: Package cedarview-drm

[Alberto Milone]

On 27/07/12 23:21, Steve Langasek wrote:
> Hi Alberto,
> 
> Reviewing the package in the new queue, I spotted a few issues.  The
> first few of these need to be fixed before I will accept the package
> into precise.  Can you please take care of these and reupload?
> 
> debian/grub.d/11_custom_cmdline: this is NIHing the grub-gfxpayload
> blacklist handling already implemented in grub via /usr/share/grub-
> gfxpayload-lists/blacklist.  Instead of shipping a file under
> /etc/grub.d which hard-codes disabling of vt handoff even when the
> hardware is not present, please add a blacklist file to this directory
> like the ones in the grub-gfxpayload-lists package and call 'update-
> grub-gfxpayload' (instead of update-grub') from your package's postinst
> and postrm (on remove/purge only, and guarded with || true).  Creating
> the blacklist should be straightforward, you're already processing a
> list of PCI IDs in debian/rules.
> 
> You should add a dependency on grub-gfxpayload-lists for this.
> 

The main reason why I didn't use this was that it gives us a black
screen until we get a 1 or 2 seconds plymouth screen and then we get to
the lightdm screen. At least this is what happens on our machines.

I'll accept your changes just in case other machines with supported
chipsets react in a
different way.

> debian/lightdm.conf: why is this necessary?  including this file in the
> package means that merely installing the driver package causes unity3d
> to stop working out of the box, even if this video hardware is not
> present.  (The same reason not to hard-disable vt.handoff.)  Does the
> Unity auto-detection of 3D support not work correctly on this hardware
> for some reason?  If it's *really* confirmed to be needed, then ok; but
> we should definitely use the autodetection if possible.

The driver's OpenGL implementation is, well, partial ;). This means that
Unity will start (as the driver passes the Unity's tests) but you won't
see anything useful on your screen.

> - debian/dirs is probably entirely pointless.  You should only need this
> file if you are shipping empty directories in the package.

Good point

> 
> - debian/copyright references http://dep.debian.net/deps/dep5/, which is
> an obsolete draft.  This should ideally be updated to conform to
> copyright-format 1.0 (http://www.debian.org/doc/packaging-manuals
> /copyright-format/1.0/).

Ok, I'm attaching the new diff with your changes (thanks for all your
work, BTW) and mine.


** Patch added: "sru-changes1.patch"
   https://bugs.launchpad.net/bugs/1025720/+attachment/3243782/+files/sru-changes1.patch

-- 
You received this bug notification because you are a member of Ubuntu
Package Archive Administrators, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1025720

Title:
  Package cedarview-drm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1025720/+subscriptions