Rejected: mcollective-plugins

[Jamie Strandboge]

Hi,

I'm sorry to inform you that mcollective-plugins is being rejected for
the following reasons:
 * agent/service/service.ddl, agent/puppetd/puppetd.ddl and
agent/iptables-junkfilter/iptables.ddl (and others) are listed in
debian/copyright as GPLv2, but they do not exist
 * agent/nettest/nettest.ddl is listed in debian/copyright as  BSD, but
it does not exist
 * several Apache 2.0 files are missing from debian/copyright (uapt,
kill, upuppet, uservice
 * a .git/ directory is present in the tarball
 * the source is not lintian clean
 * mcollective-plugins-facts-ohai.postrm could be cleaned up to use 'sed
-i' instead of the mv, cat, rm, chmod. The same can be done with the
mcollective-plugins-facts_facter.postinst
 * while the package has an orig.tar.gz file, I cannot find a proper
upstream download to verify checksums. Ideally the packaging will
include a watch file that points to a stable upstream URL. This will
help in the future to automate checksum verification. Alternatively, you
could provide clear instructions on how to regenerate the the tarball
from pristine upstream sources (but this is hard to automate with
verification and not preferred). You might be interested in the
lp-project-upload command that Dustin Kirkland wrote. I have not used it
myself, but I believe he has made changes recently to create a tarball,
sign it and upload it to an LP project.
 * the debian/ directory is not clean, and contains build files in
mcollective-plugins-facts_facter and mcollective-plugins-facts_ohai
 * there are lots of lintian warnings and errors on the binaries

I noticed that the ddl files contained copyright info and can be found
with:
for i in `find . -type f -name "*ddl"` ; do echo $i; head $i|grep
license; done

You'll want to examine the others similarly.

-- 
Jamie Strandboge             | http://www.canonical.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20110617/367477ba/attachment.pgp>