[Merge] lp:~flacoste/ubuntu-archive-tools/copy-build-scheduler into lp:ubuntu-archive-tools

[Julian Edwards]

Review: Needs Fixing
120	+ archive = distribution.getArchive(name=args[0])
121	+ if archive is None:
122	+     parser.error('unknown archive: %s' % args[0])

It might be worth adding extra validation here that the selected archive's is_copy property is True.

142	+ for build in pending_builds:
143	+     if builds_to_rescore <= 0:
144	+         break
145	+
146	+     if build.arch_tag != processor:
147	+         continue

You're going to iterate over the batch once for each architecture here, that'll create a lot of extra API requests won't it?  It might be worth sorting the batch into a dict of builds lists indexed on archtag first perhaps?

Rob said:
> Firstly the queue capacity changes over time; so that should be refreshed periodically - and it can change -fast- when QA nab machines for testing.

Well spotted :)
-- 
https://code.launchpad.net/~flacoste/ubuntu-archive-tools/copy-build-scheduler/+merge/69370
Your team Ubuntu Package Archive Administrators is requested to review the proposed merge of lp:~flacoste/ubuntu-archive-tools/copy-build-scheduler into lp:ubuntu-archive-tools.