reject of sheepdog 0.2.0-0ubuntu1
Steve Langasek
steve.langasek at ubuntu.com
Fri Jan 21 04:30:41 UTC 2011
Hi Chuck,
I'm sorry, but I'm rejecting your upload of sheepdog 0.2.0-0ubuntu1 from the
NEW queue. According to debian/copyright, the software is made available
under the terms of GPL version 2, but your copyright file doesn't direct
users to /usr/share/common-licenses/GPL-2. As such, it's legally
questionable whether we can distribute binary packages built from this
source since the terms of the GPL require that any source or binary
distribution of the software be accompanied by a copy of the license. We
understand the pointer to /usr/share/common-licenses/GPL-2 to be adequate to
meet this requirement for binary packages, but it's not sufficient to leave
users to puzzle out the correct license for themselves. Please update
debian/copyright to include the correct pointer.
BTW, you have a pair of bugs in the packaging that cancel each other out.
You have debian/rules set up to call ./autogen.sh from an
override_dh_autoconfigure target (for reasons that are unclear to me, since
the package doesn't modify any of the upstream autotools files), without
build-depending on autoconf/autotools - only on autotools-dev, which doesn't
provide any of the relevant commands. However, this doesn't stop the
package from building because there's a typo in the rule name: to have
effect the rule needs to be called 'override_dh_auto_configure' instead. I
recommend that you drop this target from debian/rules completely, and drop
the build-dependency on autotools-dev at the same time.
Otherwise the package looks fine, so with these issues resolved I'll be
happy to accept it into natty.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slangasek at ubuntu.com vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20110120/2b54f3f5/attachment-0001.pgp>
More information about the ubuntu-archive
mailing list