Reject: gkamus

[Mahyuddin Susanto]

Hello

Pada 26/02/11 04:35, Jamie Strandboge menulis:
> Hi,
> 
> I'm sorry to report I am rejecting gkamus for the following reasons:

no problem, i will to to fixing

>  * debian/copyright says it is DEP-5, but it does not contain the short
> form license text for LGPL-2+

ah.. my bad, fixed

>  * 'Same like upstream' is not a valid license and is ambiguous since
> upstream used both LGPL-2+ and GPL-2+

fixed, i writing GPL-2 rather than 'Same like upstream'

>  * the GPL-2+ license text should come after the first occurrence of the
> license, and not in a separate paragraph on its own, not attached to any
> Files

Fixed

>  * 01_fix-doc-pkg.patch has placeholder text for comments. I suggest you
> use only DEP-3 comments in your patches

Fixed

>  * the watch file uses an incorrect URL that is 404
> 

hm.. Not sure but if i run uscan seems like d/watch is coorect
$ uscan --verbose
-- Scanning for watchfiles in .
-- Found watchfile in ./debian
-- In debian/watch, processing watchfile line:
   http://sf.net/gkamus/gkamus-(.+)\.tar\.gz
-- Found the following matching hrefs:
     gkamus-0.3.tar.gz
     gkamus-0.2.tar.gz
     gkamus-0.1.tar.gz
Newest version on remote site is 0.3, local version is 0.3
 => Package is up to date
-- Scan finished

and i have re-ulpoad to revu:
http://revu.ubuntuwire.com/p/gkamus

Thanks for reviewing!

-- 
[ Mahyuddin Susanto ]
http://tripledin.wordpress.com/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 294 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20110226/ce0249ef/attachment.pgp>