Rejecting drizzle source

[Monty Taylor]

On 11/12/2010 12:03 PM, Jamie Strandboge wrote:
> Hi,
> 
> I'm sorry to report that I am rejecting the drizzle 2010.10.03-1ubuntu1
> source package because the debian/copyright file improperly lists the
> following as GPL 2:
> <snip>
> It is possible that I missed some, so please use 'licensecheck -r' to
> verify the copyright information on your own.

Thanks! Clint and I had gone through these before, but it's a big meaty
mess, so thanks for finding those errors. Fixing right now.

(PS. Clint - we _really_ need to get that hudson license-checking job
going. Sigh)

> Though I am not an upstart expert it seems the 'start' job may be more
> specific than it needs to be. This is not a blocker and if it works in
> testing, that is fine. I mention it only as a review point (I suggest
> looking at other upstart jobs such as ssh).

Thanks -I'm definitely still learning upstart myself. I cargo-culted the
start on stanza from the current MySQL package ... seemed like a good
starting point. Clint - you're the new Upstart guy - thoughts?

It's working for me in local testing, so I think I'm going to leave it
alone for now and see if I can get more specific feedback from Clint.

> While not strictly required, it is considered good form (and I would
> highly encourage you) to use DEP-3 format for your patches in
> debian/patches.

Done. Thanks.

> After fixing the above please feel free to reupload.

Re-uploaded ... thanks for the review/feedback!

Monty