REJECT: sadms

[Jamie Strandboge]

Hi,

After review of sadms, it is being rejected for the following reasons:
1. .mo files are found in the source. These should be autogenerated and
not shipped as part of the source
2. there are a lot of bashisms in scripts using /bin/sh
(bin/pre/lsb_release.sh and bin/lsb_release.sh). /bin/sh is 'dash' in
Ubuntu. See 'man checkbashisms' for details. bin/lsb_release.sh appears
to be used at least during the build process.
3. [optional, but recommended] the patches in debian/patches should
follow DEP-3 [1], but do not
4. [cosmetic] two spaces in a row in debian/control 'SADMS  takes care
of'

[1] http://dep.debian.net/deps/dep3/

-- 
Jamie Strandboge             | http://www.canonical.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20100222/d4c52be5/attachment.pgp