Rejecting brother-cups-wrapper-*

[Martin Pitt]

Hi,

I had to reject brother-cups-wrapper-*.

Since many problems affect several packages, I list the affected ones
at the beginning of each bullet point.

Grave packaging bugs, rejection reasons:
 - [-ac] no orig.tar.gz, should not be a native package

 - [-ac, -bh7, -laser1, -laser, -mfc] Architecture: shouldn't be any,
   since it depends on the lpr-drivers which are (or, rather, should
   be) "i386 amd64"

 - [-ac, -bh7] debian/copyright does not point out which files are
   distributed under which license; also, the source package does not
   ship any binary-only files

 - [-ac, -bh7, -laser1, -laser, -mfc] debian/copyright does not have
   any copyright (e. g.  "Copyright (C) 2005 Brother. Industries,
   Ltd." as in ac_src/dcp9040cn_src/SCRIPT/cupswrapperSetup_dcp9040cn)

 - [-ac, -bh7] debian/copyright does not have a copy of the Brother
   Public License (a file pointer is not sufficient; delete
   debian/copying.brother)

 - [-ac, -bh7, -laser1, -laser, -mfc] postinst is wrong; if you need
   one, wrap it in [ "$1" = configure ] and add #DEBHELPER#, but
   'chmod a+w' in postinst is wrong; please fix the file permissions
   in debian/rules, so that the files in the .deb already have the
   correct permissions

 - [-laser1, -laser, -mfc] debian/rules sed -i's original source; do
   it in the copies in debian/<packagename> instead

Other packaging problems (not sufficient for rejection, but should be
fixed):
 - [-ac, -bh7, -laser1, -laser, -mfc] Section: should be 'text'

 - [-ac, -laser1, -laser, -mfc] empty Conflicts: field (remove)

 - [-ac, -bh7, -laser1, -laser, -mfc] consider using dh_install
   instead of the horrible shell code in debian/rules. (Please see man
   dh_install); 'mv' is one of the commands which should never appear
   in debian/rules, since it is prone to break rebuilds, etc.

 - [-ac, -laser] please do not add complete files as patches; just
   ship them in debian/local/.

 - [-bh7] lots of Conflicts: to nonexisting packages
 
 - [-laser] orig.tar.gz has debian/ files, which makes the diff.gz
   useless for review; we have to live with it if the orig.tar.gz is
   otherwise unmodified from the download from upstream; if you have
   to modify it anyway, please remove debian/

Martin
-- 
Martin Pitt        http://www.piware.de
Ubuntu Developer  http://www.ubuntu.com
Debian Developer  http://www.debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20080215/6b678a00/attachment.pgp