There's just *one* set of tests that isn't passing against trunk. I haven't had time to look in to it. James and I have discussed it in this thread: <a href="https://lists.ubuntu.com/archives/storm/2009-November/001198.html">https://lists.ubuntu.com/archives/storm/2009-November/001198.html</a><div>
<br></div><div>To answer James's question, I ran the test with something that looked like this:</div><div><br></div><div> print "before select"</div><div> rlist, wlist, xlist = select.select(readers, [], [], TIMEOUT)</div>
<div> print "after select"</div><div><br></div><div>After a few iterations, "before select" will print out but "after select" won't. There may be something I'm misunderstanding about Python's threading, but I believe that means that it's blocking on the select call. Of course, another possibility is that that's a coincidence and it's deadlocking somewhere else.</div>
<div><br></div><div>If it's any help, I'm running on Karmic.</div><div><br></div><div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
- It's not clear which Oracle branch(es) need to be reviewed. I've</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
taken a quick peek at lp:~zeomega/storm/zeomega_storm and it looks</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
like it's fairly complete. Before diving in an doing a thorough</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
review, can someone involved with the work please confirm that</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
this is the right place to look and that this is where we should</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
focus review attention?</blockquote></div><div><br></div><div>The appropriate branch for Oracle is here: lp:~jbaker/storm/oracle_support</div><div><br></div><div>I made a new branch so I can update it against trunk and include *only* the Oracle support.</div>
<div><br></div><div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
- What needs to be done to prepare an environment that can be used</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
to run the test suite and exercise the changes made for these new</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
backends? Ideally, the instructions will come in the form of a</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
patch to the README file, since it already contains setup</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
instructions that describe the setup needed to run test for the</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
existing supported backends.</blockquote></div><div><br></div><div>I'll put together a more thorough readme file, but the basic way to set this up is like this:</div><div><br></div><div> 1. Set up an Oracle XE instance. On Karmic, this is pretty easy to do. I'd suggest following the instructions in the grey box here: <a href="http://www.oracle.com/technology/tech/linux/install/xe-on-kubuntu.html">http://www.oracle.com/technology/tech/linux/install/xe-on-kubuntu.html</a></div>
<div><br></div><div> 2. I had to increase the number of allowed processes since the tests create and close connections so frequently. There are probably better ways to handle this, but the easiest way is to do something like this (as sys): alter system set PROCESSES=100 scope=SPFILE;</div>
<div><br></div><div>You may have to play around with it to get it to work.</div><div><br></div><div> 3. Export an environment variable STORM_ORACLE_URI of the form 'oracle://username:password@hostname:port'. If you're using a TNS name, you can also use a URI like this: 'oracle://username:password@tns_name?tns=True'. If you're not sure which to use, you probably want to just use the hostname/port.</div>
<div><br></div><div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
- Have all contributors to the branches that are intended to land</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
signed Canonical's contributor agreement? If not, that will be</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
required before the code can be accepted. If there's any problem</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
with this, please speak up now so that we don't spend time</blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
reviewing code that won't be accepted.</blockquote></div><div><br></div><div>I have, and I believe everyone else at Zeomega has. I'll double check on it.</div><div><br>
</div>