[storm] Let's land support for Oracle!
Jason Baker
jbaker at zeomega.com
Mon Nov 30 13:22:33 GMT 2009
There's just *one* set of tests that isn't passing against trunk. I haven't
had time to look in to it. James and I have discussed it in this thread:
https://lists.ubuntu.com/archives/storm/2009-November/001198.html
To answer James's question, I ran the test with something that looked like
this:
print "before select"
rlist, wlist, xlist = select.select(readers, [], [], TIMEOUT)
print "after select"
After a few iterations, "before select" will print out but "after select"
won't. There may be something I'm misunderstanding about Python's
threading, but I believe that means that it's blocking on the select call.
Of course, another possibility is that that's a coincidence and it's
deadlocking somewhere else.
If it's any help, I'm running on Karmic.
- It's not clear which Oracle branch(es) need to be reviewed. I've
taken a quick peek at lp:~zeomega/storm/zeomega_storm and it looks
like it's fairly complete. Before diving in an doing a thorough
review, can someone involved with the work please confirm that
this is the right place to look and that this is where we should
focus review attention?
The appropriate branch for Oracle is here: lp:~jbaker/storm/oracle_support
I made a new branch so I can update it against trunk and include *only* the
Oracle support.
- What needs to be done to prepare an environment that can be used
to run the test suite and exercise the changes made for these new
backends? Ideally, the instructions will come in the form of a
patch to the README file, since it already contains setup
instructions that describe the setup needed to run test for the
existing supported backends.
I'll put together a more thorough readme file, but the basic way to set this
up is like this:
1. Set up an Oracle XE instance. On Karmic, this is pretty easy to do.
I'd suggest following the instructions in the grey box here:
http://www.oracle.com/technology/tech/linux/install/xe-on-kubuntu.html
2. I had to increase the number of allowed processes since the tests create
and close connections so frequently. There are probably better ways to
handle this, but the easiest way is to do something like this (as sys):
alter system set PROCESSES=100 scope=SPFILE;
You may have to play around with it to get it to work.
3. Export an environment variable STORM_ORACLE_URI of the form
'oracle://username:password@hostname:port'. If you're using a TNS name, you
can also use a URI like this: 'oracle://username:password@tns_name?tns=True'.
If you're not sure which to use, you probably want to just use the
hostname/port.
- Have all contributors to the branches that are intended to land
signed Canonical's contributor agreement? If not, that will be
required before the code can be accepted. If there's any problem
with this, please speak up now so that we don't spend time
reviewing code that won't be accepted.
I have, and I believe everyone else at Zeomega has. I'll double check on
it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/storm/attachments/20091130/9267111c/attachment.htm
More information about the storm
mailing list