[storm] All bugs for 0.15 fix committed - release time?

[James Henstridge]

On Thu, Aug 6, 2009 at 9:36 PM, Jason Baker<jbaker at zeomega.com> wrote:
> On Thu, Aug 6, 2009 at 1:53 AM, Jamu Kakar<jkakar at kakar.ca> wrote:
>> Hi James,
>>
>> On Tue, Aug 4, 2009 at 11:30 PM, James Henstridge<james at jamesh.id.au> wrote:
>>> It would be nice to get lp:~jamesh/storm/bug-268151 merged.  The C
>>> extension doesn't currently build under Windows, and this branch has
>>> been reported to fix that problem.
>>
>> I think this is important enough to hold up the release.  I've added
>> the bug to the 0.15 milestone.  Have you (or anybody) else tested
>> the patch on Windows?  I've reviewed the code and tested it on
>> Ubuntu and it at least doesn't break anything here.  I don't have a
>> Windows environment to test it in, or I'd do it myself.
>>
>> Thanks,
>> J.
>>
>> --
>> storm mailing list
>> storm at lists.canonical.com
>> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/storm
>>
>
>
>
> If I build this branch on Windows, I get output that looks like this.
> I'm sure it's something that I have misconfigured.  Unfortunately, I'm
> not very skilled at troubleshooting gcc errors. Any advice?
>
> C:\MinGW\bin\gcc.exe -mno-cygwin -shared -s build\temp.win32-2.5\Release\storm\c
> extensions.o build\temp.win32-2.5\Release\storm\cextensions.def -LC:\Python25\li
> bs -LC:\Python25\PCbuild -lpython25 -lmsvcr71 -o build\lib.win32-2.5\storm\cexte
> nsions.pyd
> build\temp.win32-2.5\Release\storm\cextensions.o:cextensions.c:(.text+0x429): un
> defined reference to `_imp__PyExc_TypeError'
> build\temp.win32-2.5\Release\storm\cextensions.o:cextensions.c:(.text+0x517): un
> defined reference to `_imp___Py_NoneStruct'
> build\temp.win32-2.5\Release\storm\cextensions.o:cextensions.c:(.text+0x51f): un
> defined reference to `_imp___Py_NoneStruct'
> build\temp.win32-2.5\Release\storm\cextensions.o:cextensions.c:(.text+0x58e): un
> defined reference to `_imp__PyExc_TypeError'
> build\temp.win32-2.5\Release\storm\cextensions.o:cextensions.c:(.text+0x61c): un
> defined reference to `_imp___Py_NoneStruct'

The patch was reported to work here:

    https://lists.ubuntu.com/archives/storm/2009-May/000978.html

Abdul hit similar compile errors to you, but managed to resolve them
as mentioned in that list post.

I've gone ahead and merged the branch now that it has had the second review.

James.