<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Nov 30, 2012 at 5:15 AM, John Arbash Meinel <span dir="ltr"><<a href="mailto:john@arbash-meinel.com" target="_blank">john@arbash-meinel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<div class="im"><br>
On 2012-11-29 23:57, Diogo Matsubara wrote:<br>
> Hi there,<br>
><br>
> I did exploratory testing for the manual tags and custom kernel<br>
> options features on maas 0.1+bzr1382+dfsg-0ubuntu1~ppa1 from the<br>
> experimental PPA<br>
><br>
> Here are my findings:<br>
><br>
</div>> * Should we have validation for the kernel opt field? looks like it<br>
<div class="im">> accepts any kind of data.<br>
<br>
</div>We could, but I'm not personally sure what is valid kernel options. We<br>
could try ensuring it is at least UTF8 text, I suppose.<br>
<br>
<br>
> * maas-cli maas nodes check-commissioning returns a Unrecognised<br>
> signature: POST check_commissioning o Filed<br>
> <a href="https://bugs.launchpad.net/maas/+bug/1084292" target="_blank">https://bugs.launchpad.net/maas/+bug/1084292</a> * No navigation to<br>
<div class="im">> the tag view other than from the tagged node itself<br>
<br>
</div>So you can go to "MAAS/tags/<tag-name>/view" but you're right that we<br>
don't have a tag list view. (Per prioritization, and not sure how that<br>
would end up linked from the front page, etc. There was talk of doing<br>
a cloud of tags, or whatever.)<br>
<br>
<br>
> * Manually assigning a tag without definition to a node works ok.<br>
> * Couldn't make the definitions works though. I tried to tag the<br>
> lenovo nodes in the QA lab using the following: o maas-cli maas<br>
> tag update lenovo<br>
> definition='contains(//node[@class="system"]/vendor, "Lenovo")' o<br>
<div class="im">> then rebuilding but no nodes were tagged. I tried a couple of other<br>
> variants of the definition, no luck. Any hints?<br>
<br>
</div>When I manually ask python's lxml to run that definition against the<br>
lshw you linked, it matches correctly. I wonder if it is more of a<br>
problem of your provisioning server not being able to process the<br>
hardware details correctly? (Rabbit not sending the request, the API<br>
not allowing the provisioning server to request or post back work, etc.)<br></blockquote><div><br></div><div>I tried this again and it's working as expected. I successfully tagged the lenovo nodes automatically using the maas-cli with the above definition. It was probably a misconfiguration as you mentioned. Thanks!</div>
<div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
You shouldn't need to rebuild. The act of changing the tag should<br>
rebuild for you. If it doesn't, that would also be a bug.<br></blockquote><div><br></div><div>Yes, when I changed the tag, it triggered the rebuild and the nodes were tagged accordingly. So it's likely to be a configuration problem in the first time I tried.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Can you grab the logs for the cluster workers? (logs/cluster/current,<br>
IIRC). Though that might only be in dev mode. Mabye<br>
/var/log/maas/cluster* ?<br>
<br>
<br>
John<br>
=:-><br>
<br>
> * I put the output of lshw of one lenovo node here:<br>
<div class="im">> <a href="https://pastebin.canonical.com/79350/" target="_blank">https://pastebin.canonical.com/79350/</a>. Is there a way to query for<br>
> this hardware profile from the maas-cli?<br>
><br>
> When I was testing the feature I found some issues with the docs<br>
> as well which I discussed with Nick and am including here for<br>
> completeness.<br>
><br>
</div>> * Small nitpick: the example for add a tag to all nodes is missing<br>
> a closing ' o $ maas-cli maas tags new name='intel-gpu'<br>
<div class="im">> comment='Machines which have an Intel display driver'<br>
</div>> definition='contains(//node[@id="display"]/vendor, "Intel") * The<br>
<div class="im">> usage section is in bold in the tag documentation. See<br>
</div>> <a href="https://maas.ubuntu.com/docs/quantal/maascli.html#tag" target="_blank">https://maas.ubuntu.com/docs/quantal/maascli.html#tag</a> * The tags<br>
<div class="im">> documentation mentions the option "new" in the usage section, but<br>
> in the verbose description the option is "create". See<br>
> <a href="https://maas.ubuntu.com/docs/quantal/maascli.html#tags" target="_blank">https://maas.ubuntu.com/docs/quantal/maascli.html#tags</a><br>
><br>
> Cheers, -- Diogo M. Matsubara<br>
><br>
><br>
<br>
</div>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.12 (Cygwin)<br>
Comment: Using GnuPG with undefined - <a href="http://www.enigmail.net/" target="_blank">http://www.enigmail.net/</a><br>
<br>
iEYEARECAAYFAlC4XPkACgkQJdeBCYSNAAPExwCeLZ6DvqR4ey5ko0P22X7RMrPR<br>
Sr4AoMper7OR6DF4g+L6Be7nUvVU0gD7<br>
=ElKC<br>
-----END PGP SIGNATURE-----<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Diogo M. Matsubara<br>
</div>