Hi there,<div><br></div><div>I did exploratory testing for the manual tags and custom kernel options features on maas 0.1+bzr1382+dfsg-0ubuntu1~ppa1 from the experimental PPA</div><div><br></div><div>Here are my findings:</div>
<div><ul><li dir="ltr">Should we have validation for the kernel opt field? looks like it accepts any kind of data.<br></li><li dir="ltr">maas-cli maas nodes check-commissioning returns a Unrecognised signature: POST check_commissioning</li>
<ul><li dir="ltr">Filed <a style="color:rgb(52,101,164)" href="https://bugs.launchpad.net/maas/+bug/1084292">https://bugs.launchpad.net/maas/+bug/1084292</a></li></ul><li dir="ltr">No navigation to the tag view other than from the tagged node itself<br>
</li><li dir="ltr">Manually assigning a tag without definition to a node works ok.<br></li><li dir="ltr">Couldn't make the definitions works though. I tried to tag the lenovo nodes in the QA lab using the following:</li>
<ul><li dir="ltr">maas-cli maas tag update lenovo definition='contains(//node[@class="system"]/vendor, "Lenovo")' </li><li dir="ltr">then rebuilding but no nodes were tagged. I tried a couple of other variants of the definition, no luck. Any hints?</li>
</ul><li dir="ltr">I put the output of lshw of one lenovo node here: <a href="https://pastebin.canonical.com/79350/" style="color:rgb(52,101,164)">https://pastebin.canonical.com/79350/</a>. Is there a way to query for this hardware profile from the maas-cli?</li>
</ul><div>When I was testing the feature I found some issues with the docs as well which I discussed with Nick and am including here for completeness.</div><ul><li dir="ltr">Small nitpick: the example for add a tag to all nodes is missing a closing ' <br>
<ul><li dir="ltr">$ maas-cli maas tags new name='intel-gpu' comment='Machines which have an Intel display driver' definition='contains(<a href="//node[@id="display"]/vendor," style="color:rgb(52,101,164)">//node[@id="display"]/vendor,</a> "Intel")</li>
</ul></li><li>The usage section is in bold in the tag documentation. See <a href="https://maas.ubuntu.com/docs/quantal/maascli.html#tag">https://maas.ubuntu.com/docs/quantal/maascli.html#tag</a></li><li>The tags documentation mentions the option "new" in the usage section, but in the verbose description the option is "create". See <a href="https://maas.ubuntu.com/docs/quantal/maascli.html#tags">https://maas.ubuntu.com/docs/quantal/maascli.html#tags</a></li>
</ul></div><div>Cheers,<br>-- <br>Diogo M. Matsubara<br>
</div>