[lubuntu-devel] hardinfo FTBFS fix

[Simon Quigley]

Hello Julien,

Attached is a Debian Patch (as in, needs to go in debian/patches and
added to debian/patches/series) that needs to be applied in order for
the hardinfo FTBFS to be fixed in Yakkety[1]. That page is a little
misleading, because it says the failure is only on s390x. That is not
the case, and I was able to both reproduce and fix on amd64.

Currently it is failing because of a few flag introduced in vivid
causing symbols only to be introduced as needed, if I'm understanding
the appropriate documentation[1] correctly. This broke hardinfo
because it has the "inline" prefix on the strand function, which
didn't get added into files that needed it, which in turn made
compilation errors because the needed files didn't have the strand
function. Yes, this has been broken since vivid...

The patch removes the "inline" prefix, which makes it link
successfully, and fixes the issue.

I looked to see if it was a problem in Debian as well, but it seems
that Debian doesn't build packages with that flag, so it built
normally. So this is only needed in Ubuntu.

I would normally attach a debdiff for this sort of thing, but it seems
to have a really outdated Standards-version, which (I believe) makes
it only have a diff instead of a separate debian.tar. When running
debdiff, it only displays the debian/changelog changes I used while
testing. I also believe that it's sufficient for the time being, as
uploading this is fairly trivial.

Could you please upload this fix to Yakkety if you think this is a
good thing to do? Final Beta Freeze will end within the next day or
two, and since this is a bugfix, you'll be able to upload this to the
archive.

Seth Arnold (sarnold) and Dimitri John Ledkov (xnox) helped me with
the C++ troubleshooting on IRC, so thanks to them for helping me
figure out what the issue was. :)

Let me know if you have any questions/comments/concerns, and have a nice day.

(be aware that sometimes Gmail likes to mangle attachments, please double check)

[1] http://qa.ubuntuwire.org/ftbfs/#lubuntu
[2] https://wiki.debian.org/ToolChain/DSOLinking

-- 
Simon Quigley
tsimonq2 at ubuntu.com
tsimonq2 on freenode, OFTC
-------------- next part --------------
Description: Make the strend function accessible
 This patch makes the strend function accessible by removing the `inline`
 prefix.
Author: Simon Quigley <tsimonq2 at ubuntu.com>
Last-Update: 2016-09-22
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Index: b/util.c
===================================================================
--- a/util.c
+++ b/util.c
@@ -123,7 +123,7 @@ inline gchar *size_human_readable(gfloat
     return g_strdup_printf("%.1f GiB", size / GiB);
 }
 
-inline char *strend(gchar * str, gchar chr)
+char *strend(gchar * str, gchar chr)
 {
     if (!str)
 	return NULL;