<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121730/">https://git.reviewboard.kde.org/r/121730/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The code is quite scary, I don't feel like I can give a +1 to that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If you added some testing, I could add a sneaky ship it and then we blame it on the test if it doesn't work.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On December 29th, 2014, 6:58 p.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kubuntu, LibQApt, Aleix Pol Gonzalez, and Michael Stemle.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2014, 6:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330446">330446</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=330449">330449</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=330450">330450</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=330451">330451</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libqapt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">implement proper multi-arch dependency resolution</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">using an exciting amount of spaghetti!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 330451
BUG: 330450
BUG: 330449
BUG: 330446</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">all test cases outlined in the bug reports</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am not sure existing functionality regressed, it's all a bit nasty and the lack of apt-mocing for autottesting doesn't help the cause :/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dependencyinfo.h <span style="color: grey">(14a6b635214cda032866345998af2518975b5400)</span></li>
<li>src/dependencyinfo.cpp <span style="color: grey">(9e58054a92cf96f6ba80f89626b0bc5dd075411a)</span></li>
<li>utils/qapt-deb-installer/DebInstaller.h <span style="color: grey">(8cb1197291741a31f2cee289a0845918006d86b2)</span></li>
<li>utils/qapt-deb-installer/DebInstaller.cpp <span style="color: grey">(f6b46f2b3c2d5468c7f763d5615f1e36cb292b93)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121730/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>