<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121729/">https://git.reviewboard.kde.org/r/121729/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2014, 12:31 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I like it, how hard would it be to add a unit test for this?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should be easy. Though I do wonder if we should just throw some time at figuring out a proper test setup and then take it from there. apt itself allows for 100% mock data to be supplied (package lists, caches, configs, what have you), but we seem to lack some of the facilities to construct a backend with an entire set of mock data.</p></pre>
<br />
<p>- Harald</p>
<br />
<p>On December 28th, 2014, 11:27 p.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kubuntu, LibQApt, Aleix Pol Gonzalez, and Michael Stemle.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2014, 11:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libqapt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is a QString property that may be empty or contain the multiarch
annotation of a dependency
looks like this:
"Depends: foo:any"
this will enable deb-installer to properly handle Multi-Arch: allow mode</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dependencyinfo.h <span style="color: grey">(3ce031ac37b3684b048ddc0f353b5f20b1b92e6f)</span></li>
<li>src/dependencyinfo.cpp <span style="color: grey">(9e58054a92cf96f6ba80f89626b0bc5dd075411a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121729/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>