<html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="https://git.reviewboard.kde.org/r/121168/">https://git.reviewboard.kde.org/r/121168/</a> </td> </tr> </table> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> On November 18th, 2014, 3:19 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It won't be fixed. Change major version is really bad idea. Close review request and read INSTALL.</pre> </blockquote> On November 18th, 2014, 3:22 p.m. UTC, Aleix Pol Gonzalez wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand your review. Why is it a bad idea? What do you want me to see in INSTALL?</pre> </blockquote> On November 18th, 2014, 4:08 p.m. UTC, Albert Astals Cid wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changing major version is a very good idea, qca compiled with Qt4 and qca compiled with Qt5 are totally incompatible with eachother, so they should not have the same major version. Why do you say they should have the same major version number?</pre> </blockquote> On November 18th, 2014, 9:25 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> Why is it a bad idea? What do you want me to see in INSTALL? </blockquote> QCA_SUFFIX</pre> </blockquote> On November 18th, 2014, 9:30 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> Changing major version is a very good idea </blockquote> Ok, how to have both qca-devel and qca-qt5-devel subpackages in one system? Both packages in this case will have libqca.so but first => libqca.so.2 and second => libqca.so.3 . Do you can resolve this issue? Why you can't use QCA_SUFFIX? I give you all tools to install qca and qca-qt5 in parallel. Just use them. And don't argue with me.</pre> </blockquote> On November 18th, 2014, 9:43 p.m. UTC, Albert Astals Cid wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> And don't argue with me. </blockquote> Really? This is your way of treating contributors?</pre> </blockquote> On November 18th, 2014, 9:56 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This question allready was discussed before. Requester can't answer why he can't just use QCA_SUFFIX. And why I must use hard-coded another library. But he was sure that I must do as he said. I will try to find that review request.</pre> </blockquote> On November 18th, 2014, 9:57 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any find tool in git.reviewboard.kde.org</pre> </blockquote> On November 18th, 2014, 10:03 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://git.reviewboard.kde.org/r/119939/</pre> </blockquote> On November 18th, 2014, 10:14 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can explain me why you can't use QCA_SUFFIX or maybe somebody prohibits you to use it?</pre> </blockquote> On November 18th, 2014, 10:15 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Or maybe there is standard which force me to change major version?</pre> </blockquote> On November 18th, 2014, 10:25 p.m. UTC, Martin Klapetek wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Speaking of not answering questions or explaining...the RR you linked have 5 people from different major distributions asking questions which you have left unanswered and also suggesting you should do that and you did not /explain/ why you would not accept it. I don't know what standard you keep looking for...those comments are from packagers. And packagers are the people that deal with these things every single day; they get the stuff you create to users. They know the best. There's nothing to argue. If anyone should not argue, it's you with them, really. As for this RR, note Dan's reply in the other -- "I'd like to point out that soname bump is usually not enough. It will prevent conflict of the base package, but it will lead to conflicts with -devel packages, which install the library without soname."</pre> </blockquote> On November 18th, 2014, 10:43 p.m. UTC, Albert Astals Cid wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> This question allready was discussed before. Requester can't answer why he can't just use QCA_SUFFIX. And why I must use hard-coded another library. But he was sure that I must do as he said. I will try to find that review request. https://git.reviewboard.kde.org/r/119939/ </blockquote> Well I wasn't aware of that review request, but even if i was, what's the reason to be impolite and say "don't argue with me"? Anyway, i'm not interested in discussing with impolite people. Enjoy!</pre> </blockquote> On November 18th, 2014, 10:52 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this case NO any standarts which I should/must follow. Case when from the same sources can be compiled some not ABI compatibles libraries is specific. No standart way to handle this. So IMO library name shouldn't be depended from any other libraries against which it compiled. So I use by default qca name. But I know what sometimes distros provides some versions of one library. For this case I did QCA_SUFFIX it allows to have various version on single library installed in parallel. I think it will be enough.</pre> </blockquote> On November 19th, 2014, 8:49 a.m. UTC, Andrey Bondrov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QCA_SUFFIX is a good way to have both Qt4 and Qt5 qca libraries installed, including both development packages. Here is how I build Qt5 version of qca: https://abf.rosalinux.ru/openmandriva/qca2-qt5/blob/master/qca2-qt5.spec</pre> </blockquote> On November 19th, 2014, 9 a.m. UTC, Andrey Bondrov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could be nice to have qt5 as the default (=recommended) QCA_SUFFIX for Qt5 build. Otherwise we may end with some blobs built for Ubuntu (or another distro) missing required qca2 library only because of different soname/filename.</pre> </blockquote> On November 19th, 2014, 11:04 a.m. UTC, Martin Klapetek wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">--> https://git.reviewboard.kde.org/r/119939/ - that's what that RR is about.</pre> </blockquote> On November 19th, 2014, 11:18 a.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Andrey, use stable release http://delta.affinix.com/download/qca/2.0/qca-2.1.0.tar.gz</pre> </blockquote> On November 19th, 2014, 11:27 a.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Andrey, QCA_INSTALL_IN_QT_PREFIX is not cache variable so you can't set this in command line. qca-gnupg requires gnupg package (prefer 1.4 version) I think should be added <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Requires: gnupg</code>. Also there are documentation. I think it will be good to give these to developers <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make doc && cp -r apidocs/html /some/path</code></pre> </blockquote> On November 19th, 2014, 11:38 a.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Andrey, I will add suitable warning to cmake for users who build on Linux for Qt5 without QCA_SUFFIX. Please provide me text for this warning.</pre> </blockquote> On November 19th, 2014, 12:06 p.m. UTC, Andrey Bondrov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanx for your advices, I updated package to 2.1.0 stable and adjusted spec file. As for the warning, I guess this text is OK: "You don't have QCA_SUFFIX set. Please note that the recommended way of building Qt5 version of qca for Linux distributions is to set QCA_SUFFIX to qt5 (-DQCA_SUFFIX=qt5)."</pre> </blockquote> On November 19th, 2014, 8:27 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Andrey, you build docs but didn't to copy to %{buildroot}. Also use QCA_MAN_INSTALL_DIR to set properly path for manpages.</pre> </blockquote> On November 20th, 2014, 2:29 a.m. UTC, Andrey Bondrov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ivan, I use "%doc build/apidocs" inside devel package's %files instead of copying build/apidocs to buildroot. And thanx for the hint with QCA_MAN_INSTALL_DIR :-)</pre> </blockquote> On November 20th, 2014, 7:58 a.m. UTC, Hrvoje Senjan wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> QCA_SUFFIX is a good way to have both Qt4 and Qt5 qca libraries installed, including both development packages. </blockquote> Hm, but both development packages cannot be installed at the same time. The CMake files are installed into the same dir name for both Qt4 and Qt5 builds, regardless of the QCA_SUFFIX</pre> </blockquote> On November 20th, 2014, 9:40 a.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Renaming config files is not correct. I can't just use suffix for them. find_package can handle only with single name. I don't knot how to handle with this. Maybe there is a way to distinct Qt version in qca config files.</pre> </blockquote> On November 21st, 2014, 3:27 p.m. UTC, Michael Palimaka wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is renaming the package/config file incorrect? Numerous packagers suggest you adopt an approach used by pretty much every major library supporting both Qt4 and Qt5, and you consistently refuse to even entertain it. We're forced to recommend to our users to avoid software using QCA because it's just not possible to support properly.</pre> </blockquote> On November 21st, 2014, 5:42 p.m. UTC, Aleix Pol Gonzalez wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the reason why you don't want to tie the Config file name to the suffix is simple. If you did that, you'd make developers to tie their source code (i.e. find_package(QCA-qt5)) to whatever the distribution decided to call the QCA_SUFFIX. FWIW, I don't think it should be up to the packager to define what it's called, the only reason we need the suffix is because we need co-installability of the library between Qt4 and Qt5.</pre> </blockquote> On November 21st, 2014, 5:46 p.m. UTC, Michael Palimaka wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's correct, I meant renaming in general (ie. to a fixed string, upstream)</pre> </blockquote> On November 22nd, 2014, 1:18 a.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> Why is renaming the package/config file incorrect? </blockquote> My failure. I read cmake documentation again. So <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">find_package</code> has <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">NAMES</code> option what can contains alternative possible config names. So I can freely use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QCA_SUFFIX</code> for cmake config files too.</pre> </blockquote> On November 22nd, 2014, 1:33 a.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commits <a href="http://quickgit.kde.org/?p=qca.git&a=commitdiff&h=2c58be171e8478f03d8a724640f40e36826c6893&hp=25860ff244205b7cc61fc5c8ed06bcbe9f12957f" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cmake: warn user when QCA_SUFFIX is not set</a> <a href="http://quickgit.kde.org/?p=qca.git&a=commitdiff&h=66447d0454591f4c1deb5f4c988c6027194b1335" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cmake: apply QCA_SUFFIX for cmake config module names</a></pre> </blockquote> On November 24th, 2014, 9:01 p.m. UTC, Jeremy Whiting wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ivan, I appreciate the two commits you made to simplify things, however it seems that's not enough. For example say I want to create an application (or build an existing one) that uses qca built for qt5. If I add find_package(QCA-qt5) it will work only on distributions who built qca with -DQCA_SUFFIX=-qt5 but not another distro that built with -DQCA_SUFFIX=5 or another that used -DQCA_SUFFIX=qt5. This is very unfortunate. Many many packagers have commented on this review and the other review that a solution within qca sources itself is ideal and wanted. You have repeatedly ignored questions of why you are against such a change besides asking for some standard that will never exist. If you would like to help users of qca use qca you should propose a solution or accept one of these solutions that has already been presented to you. I fear if you do neither of these a fork of qca may happen at some point so we can get past this issue and move on.</pre> </blockquote> On November 25th, 2014, 12:02 a.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You don't. You add. find_package(Qca NAMES Qca-qt5 Qca-5 Qca-bla-bla-bla) Package always names Qca. QCA is wrong. Qca-qt5 is wrong too. By fact you can use just <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">find_package(Qca-qt5)</code> it will work but it is not correct. In this case you get <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Qca_qt5_LIBRARY</code> not <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Qca_LIBRARY</code>. Look at <a href="http://pkgs.fedoraproject.org/cgit/qt5-qtbase.git/tree/qt5-qtbase.spec#n450" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">qt5-qtbase</a> package in Fedora. In Fedora Qt5 uses /usr/lib{%suffix}/qt5 for most of Qt5 stuff (not regular HFS). But the most important in our case Fedora makes -qt5 suffix for Qt5 developer tools. Qt5 do not do that. It's not a library. Something another. I just say that it is a normal practice when maintainer of package do required hacks to avoid conflicts. <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> I fear if you do neither of these a fork of qca may happen at some point so we can get past this issue and move on. </blockquote> Do fork it's not problem. If you sure that hard-coded alternative name it is good reason for this. And if you want to support this library. No any problems.</pre> </blockquote> On November 25th, 2014, 2:24 p.m. UTC, Michael Palimaka wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How can we expect every consumer to do find_package(Qca NAMES Qca-qt5 Qca-5 Qca-bla-bla-bla)? There needs to be a sane upstream default.</pre> </blockquote> On November 25th, 2014, 3:41 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> How can we expect every consumer to do find_package(Qca NAMES Qca-qt5 Qca-5 Qca-bla-bla-bla)? </blockquote> cmake shows warning. It's should be enough. <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> There needs to be a sane upstream default. </blockquote> There is sane upstream default is Qca.</pre> </blockquote> On November 25th, 2014, 3:46 p.m. UTC, Michael Palimaka wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What does a warning have to do with anything? Are you expecting every Qca consumer to enumerate every possible suffix and just hope that it was built with one of them, or do you seriously expect downstream to patch every single Qca consumer?</pre> </blockquote> On November 25th, 2014, 4:02 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are two ways handle this. Maintainer of package will report bugreport to consumer to add new suffix or he can just write very simple patch. To use correct suffix for him distro. Patches are OK. The most of packages uses patches or extra actions to build and install soft not just <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">./configure && make && make install</code>. Or you can provide some QCA_SUFFIX in your consumer to allow maintainer to set correct suffix.</pre> </blockquote> On November 25th, 2014, 4:05 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My task/issue is give your a way to set all what you want. Your task/issue just use them all. It is my point view. If that way what I provided you is not your fit. I will work next to improve it. But don't ask me to change defaults.</pre> </blockquote> On November 25th, 2014, 4:08 p.m. UTC, Martin Klapetek wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> Patches are OK. </blockquote> No they are not. <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> The most of packages uses patches or extra actions to build and install soft </blockquote> No they do not. Moreover, you still seem to be missing the key issue - this way, you put extra work on everybody. Why do you want to put extra work on everybody when you can help everybody by accepting a single-line patch. That just makes no sense and it is not really a team-play. Ask any packager in the world what they think about downstream patches (and soo many have replied here and in the other). Why make everyone's life harder... :(</pre> </blockquote> On November 25th, 2014, 4:09 p.m. UTC, Michael Palimaka wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other packagers, are you interested in a shallow fork? I think it's pretty clear at this point that Ivan is not grounded in reality and we will not get anything other than the middle finger from him.</pre> </blockquote> On November 25th, 2014, 4:27 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> extra work on everybody </blockquote> Add <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-DQCA_SUFFIX=qt5</code> is not extra work. It is normal work for any maintainer. <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> That just makes no sense and it is not really a team-play </blockquote> In team-play I can have own opinion. I mustn't to do all what somebody says me. You not my employer. I do it for free just as my hobby not more. I started because nobody care about QCA and I wanted to port psi to Qt5.</pre> </blockquote> On November 25th, 2014, 4:30 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Michael, just do not use original QCA do fork if you want. You can think that I shows <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">middle finger</code>. If you don't agree with my work you can drop all my patches, write own cmake scripts and port to Qt5 again. It is not a problem. If you really think so.</pre> </blockquote> On November 25th, 2014, 4:31 p.m. UTC, Michael Palimaka wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is extra work. No other package requires that sort of nonsense.</pre> </blockquote> On November 25th, 2014, 4:40 p.m. UTC, Michael Palimaka wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I've previously mentioned, it's not feasible for me to support coinstalled Qt4/Qt5 QCA in its current form - so no, we won't be using it (we have no choice), but thanks anyway.</pre> </blockquote> On November 25th, 2014, 5:19 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can everyone take a calm breath? Suggesting to fork over such a trivial issue is a bit silly, IMHO. Especially considering that this is a cryptographic library, even a small chance that an eventual fork loses a patch could have pretty bad results, we don't want more issues to security@kde.org. :-) Ivan: Is there any specific reason that you don't want this change? If there is some Psi source or build system that needs to be changed, just tell me (or us), and I'll try to come up with a patch. :-) Would defaulting to setting the suffix for Qt5 be acceptable, with an option to remove/change it? As an application developer I would prefer the name to be the same across distros, to make it easier for me. But I respect your decision, and with the cmake warning hopefully no distros decide to chose something else.</pre> </blockquote> On November 25th, 2014, 8:12 p.m. UTC, Ivan Romanov wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> Ivan: Is there any specific reason that you don't want this change? </blockquote> Martin. As I allready had mentioned many times. Only reason that is not correct to change library (and other stuff) name. Library name mustn't be related from another libraries. Also in common case every distros provides only one version of each library. As I know it is Linux philosophy. When need to provide another version of some library it is non standard case. In our case we have Qt4 library which is default (and standard) and Qt5 library which is non-standard but distrod provide this library to make soft transition and allow all software migrage to Qt5 without big stress. So from this point of view it is not correct to support alternative library names for cases Qt4 and Qt5 installed in parallel. So next my task is provide a way to do soft transition to Qt5. I did this when added QCA_SUFFIX which must solve all problems. Also I see in the future when will no be Qt4 and will be only Qt5. In that time qt5 suffix will be nonsense. Also suffix nonsense on Windows and Mac OS X where all libraries is bundled in app. Make resume. Suffix now is a hack to do soft migration to Qt5. In the future it won't be used. <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> If there is some Psi source or build system that needs to be changed </blockquote> No any psi-related issues. <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> But I respect your decision. </blockquote> Very big thanks!</pre> </blockquote> On November 25th, 2014, 11:27 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> In our case we have Qt4 library which is default (and standard) and Qt5 library which is non-standard but distrod provide this library to make soft transition and allow all software migrage to Qt5 without big stress. </blockquote> Yes, this is what archlinux (the distro I use) is doing at the moment; the official QCA package is just the normal Qt4 version without any suffix (and this is what everything supported is built against), the qt5 version is only available in the unofficial, user-controlled AUR repository, and there with the suggested qt5 suffix. <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> Also I see in the future when will no be Qt4 and will be only Qt5. In that time qt5 suffix will be nonsense. </blockquote> I think the problem some of the distro people are having is that if they now want to ship both qt4 and qt5 applications using QCA, they will have to rebuild everything that is built against qca with the qt5 suffix against qca without the suffix in the future, or continue using the suffix forever (which is what I think they are going to do). <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> Also suffix nonsense on Windows and Mac OS X where all libraries is bundled in app. </blockquote> I agree, this is mostly an issue for applications on Linux/linux distributions. But to summarize; I agree that using a qt5 suffix is pretty ugly and not very elegant, but a pragmatic solution to the problem on linux would be to add the suffix by default (especially since it seems like a lot of distributions are going to do it anyways). But you're the one maintaining and doing most of the work on QCA, so it's your call. Lastly, thank you for working on QCA, caring enough to respond to people, and implementing the current suffix solution. :-)</pre> </blockquote> </blockquote> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello folks, the Community Working Group has been asked to step in here. This is an important issue, affecting a lot of people. I would like to thank each of you who weighed in here, because you all care deeply about the KDE community and keeping our software excellent. I'm seeing a bit of arguing from position here on both "sides" though. What is important is solving the problem. Please can we get to a dialogue where the goal is crafting a solution which will work for everyone? Again, thank you everyone reading this.</pre> - Valorie On November 18th, 2014, 2:53 p.m. UTC, Aleix Pol Gonzalez wrote: <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for Kubuntu and Ivan Romanov.</div> <div>By Aleix Pol Gonzalez.</div> Updated Nov. 18, 2014, 2:53 p.m. <div style="margin-top: 1.5em;"> Repository: qca </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Qt4 and Qt5 versions can't have the same so-name. An application compiled against Qt4 won't work if suddenly it finds a Qt5 dependency.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stills builds, things didn't seem to break.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>CMakeLists.txt (7adacf1)</li> </ul> <a href="https://git.reviewboard.kde.org/r/121168/diff/" style="margin-left: 3em;">View Diff</a> </td> </tr> </table> </div> </body> </html>