<div dir="ltr"><div>Aleix, much thanks! I appreciate the feedback.</div><div><br></div>That's where the test lives (soon to be plural once I'm done with this push). It's a Perl convention (I started doing TDD years ago with Perl and kinda just got stuck on the conventions), and I'd be happy to adapt to a different convention if it would be more appropriate.<div>
<br></div><div>If you `make test` you'll see that my test runs (it'll prompt for a password for polkit, but it won't modify your /etc files, only files in ./t/data).</div></div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Wed, Dec 18, 2013 at 12:06 PM, Aleix Pol <span dir="ltr"><<a href="mailto:aleixpol@kde.org" target="_blank">aleixpol@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">On Sat, Dec 14, 2013 at 8:00 AM, Michael Stemle <span dir="ltr"><<a href="mailto:themanchicken@gmail.com" target="_blank">themanchicken@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Hey all, I have mostly finished my changes to libqapt. Below is the changelog for this change as well as JonT's as-of-yet un-released changes upon which my changes are based.<div>
<br></div><div>Please give me any feedback you may have. I'm going to continue to go through it with the KDE standards in mind, but if you have any tools which automatically validate code and you notice I'm failing, please link me to a document showing me how to run the validation myself so that I can make sure that I can get the problems resolved.</div>
<div><br></div><div>Also, there are warnings along the lines of:</div><div><div><br></div><div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp: In member function ‘void QApt::Package::setPurge()’:<br></div>
<div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp:1270:24: warning: ‘void pkgProblemResolver::InstallProtect()’ is deprecated (declared at /usr/include/apt-pkg/algorithms.h:137) [-Wdeprecated-declarations]</div>
<div> Fix.InstallProtect();</div><div> ^</div><div>but I don't know libapt-pkg very well. If you know what the correct way to resolve these errors is, please shoot me a message.</div><div><br>
</div><div>Much thanks.</div><div><br></div><div>Here's the git branch: <a href="https://github.com/manchicken/libqapt" target="_blank">https://github.com/manchicken/libqapt</a></div>
<div><br></div><div>Changes:</div><div><div>2.1.1:</div><div>======</div><div>- Features:</div><div> * Handles multiple sources.list-formatted files</div><div> * Supports arbitrary sources.list loading, parsing, and writing</div>
<div> (meaning you can load any source file directly, or use the default set.)</div><div> * Added the ability to query a list of all loaded sources.list files.</div><div> * You can now fetch only the files for a specific repository.</div>
<div>- Bugfixes:</div><div> * There was a bug in the unreleased alpha where removing all entries from</div><div> any file could potentially result in overwriting the defaulatet /etc/apt/sources.list.</div><div><br></div>
<div>2.1: (as of 2.1 alpha, unreleased)</div><div>======</div><div>- Features:</div><div> * Added a new SourcesList class for manipulating APT source list files.</div><div> * Added a new SourceEntry class for manipulating individual APT sources within source list</div>
<div> files.</div><div> * Added a "frontend capabilities" API which frontends use to advertise which forms of user</div><div> interaction they support during the commit process. (Config file conflict, untrusted packages</div>
<div> prompt, debconf, etc) This will prevent frontends that don't explicitly support these</div><div> interactions from hanging the commit process indefinitely.</div><div> * Add support for the new Synaptic marking file syntax (BKO: #314549)</div>
<div>- Bugfixes:</div><div> * Stop leaking a file descriptor when reading APT pin files.</div><div> * Stop taking the address of a temporary variable in the package search function.</div><span><font color="#888888"><div>
<br></div>-- <br>~ Michael D. Stemle, Jr.
</font></span></div></div></div>
<br></div></div>--<br>
kubuntu-devel mailing list<br>
<a href="mailto:kubuntu-devel@lists.ubuntu.com" target="_blank">kubuntu-devel@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel" target="_blank">https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel</a><br>
<br></blockquote></div><br></div><div class="gmail_extra">Hi Michael,</div><div class="gmail_extra">I'm happy to see that you're being so thorough in the development of those features libqapt (especially with the addition of unit tests, really appreciated). I'm not the most adequate person to approve the patch, but as a muon developer I'd really like to see these changes in.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">By the way, why does it have a directory called "t"?</div><span class="HOEnZb"><font color="#888888"><div class="gmail_extra"><br></div><div class="gmail_extra">
Aleix</div></font></span></div>
<br>--<br>
kubuntu-devel mailing list<br>
<a href="mailto:kubuntu-devel@lists.ubuntu.com">kubuntu-devel@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel" target="_blank">https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>~ Michael D. Stemle, Jr.
</div>