<p dir="ltr">Okay, that makes sense. I wish I had a better way of wrapping tests around that part of the code. Adding and removing sources files now has a bunch of new tests, but installing packages seems like a tricky thing to test. It seems like the only way to test this change would be to try installing stuff. </p>
<div class="gmail_quote">On Dec 17, 2013 12:01 AM, "Jonathan Thomas" <<a href="mailto:echidnaman@gmail.com">echidnaman@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Here's what this function's documentation in algorithms.cc has to say:<div><br></div><div><pre style="line-height:14px;font-size:12px;margin-bottom:0px;list-style:none;margin-top:0px;padding:0px">
<span style="margin:0px;padding:0px;list-style:none;color:green">// ProblemResolver::InstallProtect - deprecated cpu-eating no-op /*{{{*/
</span><span style="margin:0px;padding:0px;list-style:none;color:green">// ---------------------------------------------------------------------
</span><span style="margin:0px;padding:0px;list-style:none;color:green">/* Actions issued with FromUser bit set are protected from further
modification (expect by other calls with FromUser set) nowadays , so we
don't need to reissue actions here, they are already set in stone. */</span></pre><pre style="line-height:14px;font-size:12px;margin-bottom:0px;list-style:none;margin-top:0px;padding:0px"><span style="margin:0px;padding:0px;list-style:none;color:green"><br>
</span></pre></div><div class="gmail_extra"><br><br><div class="gmail_quote">Looks like it can safely be removed. I was only ever calling it because Synaptic did anyway :P</div><div class="gmail_quote"><br></div><div class="gmail_quote">
On Mon, Dec 16, 2013 at 11:40 PM, Michael Stemle <span dir="ltr"><<a href="mailto:themanchicken@gmail.com" target="_blank">themanchicken@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hey all, in cleaning up libqapt for the KDE review board I'm wanting to kill these InstallProtect() deprecation warnings I'm seeing. Here's what I mean:<div><br></div><div><div>[ 14%] Building CXX object src/CMakeFiles/qapt.dir/backend.o</div>
<div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/backend.cpp: In member function ‘bool QApt::Backend::loadSelections(const QString&)’:</div><div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/backend.cpp:1295:24: warning: ‘void pkgProblemResolver::InstallProtect()’ is deprecated (declared at /usr/include/apt-pkg/algorithms.h:137) [-Wdeprecated-declarations]</div>
<div> Fix.InstallProtect();</div><div> ^</div><div>[ 15%] Building CXX object src/CMakeFiles/qapt.dir/cache.o</div><div>[ 17%] Building CXX object src/CMakeFiles/qapt.dir/package.o </div>
<div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp: In member function ‘QUrl QApt::Package::screenshotUrl(QApt::ScreenshotType) const’:</div><div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp:578:12: warning: enumeration value ‘UnknownType’ not handled in switch [-Wswitch]</div>
<div> switch (type) {</div><div> ^</div><div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp: In member function ‘void QApt::Package::setRemove()’:</div><div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp:1250:24: warning: ‘void pkgProblemResolver::InstallProtect()’ is deprecated (declared at /usr/include/apt-pkg/algorithms.h:137) [-Wdeprecated-declarations]</div>
<div> Fix.InstallProtect();</div><div> ^</div><div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp: In member function ‘void QApt::Package::setPurge()’:</div><div>/home/manchicken/Documents/Devel/kubuntu/libqapt/src/package.cpp:1270:24: warning: ‘void pkgProblemResolver::InstallProtect()’ is deprecated (declared at /usr/include/apt-pkg/algorithms.h:137) [-Wdeprecated-declarations]</div>
<div> Fix.InstallProtect();</div><div> ^</div><div><br></div><div>I have found exactly zero documents describing this part of apt-pkg, and I'm hoping someone else might have some context or advice surrounding this method, its prior usefulness, and maybe even some ideas on how to migrate away from it. If they're going to remove this method at some point, I'd like us to be off of it if possible so that we don't end up with an emergency.</div>
<div><br></div><div>Much thanks.</div><span><font color="#888888"><div><br></div>-- <br>~ Michael D. Stemle, Jr.
</font></span></div></div>
<br>--<br>
kubuntu-devel mailing list<br>
<a href="mailto:kubuntu-devel@lists.ubuntu.com" target="_blank">kubuntu-devel@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel" target="_blank">https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel</a><br>
<br></blockquote></div><br></div></div>
<br>--<br>
kubuntu-devel mailing list<br>
<a href="mailto:kubuntu-devel@lists.ubuntu.com">kubuntu-devel@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel" target="_blank">https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel</a><br>
<br></blockquote></div>