Review Request 127249: Fix muon not closing with window close button.

Carlo Vanini silhusk at
Thu Mar 3 00:33:13 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated March 3, 2016, 12:33 a.m.)


This change has been marked as submitted.

Review request for Kubuntu and Muon Package Management Suite.


Submitted with commit 465ca5fcf203fa190b90823907f358954b922f5f by Carlo Vanini to branch master.

Bugs: 358659

Repository: muon


The variable m_canExit was not initialized and did prevent muon from exiting when closed from the window manager.  Remove it because it is never changed and remove canExit() because it is in the wrong place anyway to prevent exiting while acting on packages. It should be in backend.


  src/MainWindow.cpp 466ea4bc00773dbd5353a477a10bbb125d021287 
  src/muonapt/QAptActions.h 33db6e19d1a1a7bed3d15c8a33cabe51242d661c 



* open muon
* close by clicking the X button in the window decoration or with Alt+F4

Closing with File -> Exit or Ctrl+Q does not call MainWindow::queryClose() and therefore di always work.


Carlo Vanini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kubuntu-devel mailing list