Review Request 126923: Make sure qapt-check doesn't get called repeatedly

Aleix Pol aleixpol at kde.org
Sat Jan 30 11:27:26 UTC 2016


On Fri, Jan 29, 2016 at 8:02 PM, Mitch Golden <mgolden at mitchgolden.com> wrote:
> Thanks for doing this - I have noticed my machine nearly falling over when
> the updater runs.  The updater itself pegs the CPU, and then spawns north of
> 100 apt-check processes.
>
> Does this fix correct the high CPU in the updater itself?
>
>   - Mitch Golden
>
> On Thu, 28 Jan 2016, Aleix Pol Gonzalez wrote:
>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://git.reviewboard.kde.org/r/126923/
>> -----------------------------------------------------------
>>
>> Review request for Kubuntu.
>>
>>
>> Bugs: 347602 and 358359
>>    https://bugs.kde.org/show_bug.cgi?id=347602
>>    https://bugs.kde.org/show_bug.cgi?id=358359
>>
>>
>> Repository: discover
>>
>>
>> Description
>> -------
>>
>> Simplify the process that checks for system upgrades.
>> - Makes sure it's only run when needed.
>> - Doesn't recreate the QProcess instance.
>>
>>
>> Diffs
>> -----
>>
>>  libdiscover/backends/ApplicationBackend/ApplicationNotifier.cpp 25abc99
>>
>> Diff: https://git.reviewboard.kde.org/r/126923/diff/
>>
>>
>> Testing
>> -------
>>
>> Not much, seems to work on my test Kubuntu system, waiting for feedback.
>>
>>
>> Thanks,
>>
>> Aleix Pol Gonzalez
>>
>>
>

Yes, that's why I asked you if you can give it a try.

Aleix



More information about the kubuntu-devel mailing list