Review Request 126709: add keyboard shortcut to focus search box
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jan 11 13:55:02 UTC 2016
> On Jan. 11, 2016, 1:24 p.m., Aleix Pol Gonzalez wrote:
> > Looks good!
> >
> > Can you commit it?
>
> Carlo Vanini wrote:
> No, please push it for me. Also the other one, RR #126710 Thanks!
Will do, meanwhile: https://techbase.kde.org/Contribute/Get_a_Contributor_Account
Set me as referral, if you want.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126709/#review90888
-----------------------------------------------------------
On Jan. 10, 2016, 7:53 p.m., Carlo Vanini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126709/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 7:53 p.m.)
>
>
> Review request for Kubuntu and Muon Package Management Suite.
>
>
> Bugs: 299763, 312568 and 325536
> http://bugs.kde.org/show_bug.cgi?id=299763
> http://bugs.kde.org/show_bug.cgi?id=312568
> http://bugs.kde.org/show_bug.cgi?id=325536
>
>
> Repository: muon
>
>
> Description
> -------
>
> Add keyboard shortcut to move focus to the search box, and give it focus at startup.
>
> If the box is hidden, e.g. by changes preview, the focus is not changed. Otherwise you could change the content of the search box without seeing it.
>
>
> (if accepted, please push it for me)
>
>
> Diffs
> -----
>
> src/MainWindow.h 0d6c02248b69e38477ad0bce2429ea87dd83379b
> src/MainWindow.cpp c3d6a83e14c7f10361b49e2a9e08426dfed659c0
> src/PackageModel/PackageWidget.h 02abcfcb08d98b58508f7eff18b902a7372bf55a
> src/PackageModel/PackageWidget.cpp 1d0c377d31724b70754e7636438e5c286b6e5830
>
> Diff: https://git.reviewboard.kde.org/r/126709/diff/
>
>
> Testing
> -------
>
> * start muon: the search box has focus
> * tab or click to change focus
> * press Ctrl+F and the search box gains focus again
>
>
> Thanks,
>
> Carlo Vanini
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20160111/7eedc9a4/attachment-0001.html>
More information about the kubuntu-devel
mailing list