Review Request 126710: rename icons

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jan 11 12:25:05 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126710/#review90889
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Jan. 10, 2016, 8:07 p.m., Carlo Vanini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126710/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 8:07 p.m.)
> 
> 
> Review request for Kubuntu and Muon Package Management Suite.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> Rename icon files to solve CMake (ECM) warnings.
> 
> ```
> CMake Warning (dev) at /usr/share/ECM/modules/ECMInstallIcons.cmake:248 (message):
>   "hi22-apps-muon.png" has characters before the size; it should be renamed
>   to "22-apps-muon.png"
> Call Stack (most recent call first):
>   src/icons/CMakeLists.txt:1 (ecm_install_icons)
> ```
> 
> (if accepted, please push it for me)
> 
> 
> Diffs
> -----
> 
>   src/icons/CMakeLists.txt ed8b0650c27171b70876d6b33a24efae475931ab 
>   src/icons/hi128-apps-muon.png  
>   src/icons/hi16-apps-muon.png  
>   src/icons/hi22-apps-muon.png  
>   src/icons/hi256-apps-muon.png  
>   src/icons/hi32-apps-muon.png  
>   src/icons/hi48-apps-muon.png  
>   src/icons/hi64-apps-muon.png  
>   src/icons/hisc-apps-muon.svgz  
> 
> Diff: https://git.reviewboard.kde.org/r/126710/diff/
> 
> 
> Testing
> -------
> 
> `make install` still installs the icons in the same path as before (hicolor).
> 
> 
> Thanks,
> 
> Carlo Vanini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20160111/c0a74861/attachment.html>


More information about the kubuntu-devel mailing list