[Merge] ~wxl/kubuntu-packaging/+git/kdiagram:kubuntu_unstable into ~kubuntu-packagers/kubuntu-packaging/+git/kdiagram:kubuntu_unstable

Walter Lapchynski wxl at ubuntu.com
Thu Dec 8 18:05:37 UTC 2016


Walter Lapchynski has proposed merging ~wxl/kubuntu-packaging/+git/kdiagram:kubuntu_unstable into ~kubuntu-packagers/kubuntu-packaging/+git/kdiagram:kubuntu_unstable.

Requested reviews:
  Kubuntu Packagers (kubuntu-packagers)

For more details, see:
https://code.launchpad.net/~wxl/kubuntu-packaging/+git/kdiagram/+merge/312853

To resolve the immediate problem with
http://kci.pangea.pub/job/merger_kdiagram/
I updated libkgantt-dev.install for *QchTargets which was changed from QCHTargets.

Along the way, I added a watch file and updated the symbols. I ended up with three missing symbols:
 * vtable for KChart::BarDiagram::BarDiagramType
 * vtable for KChart::LineDiagram::LineDiagramType
 * KGantt::GraphicsScene::clearConstraintItems()
but it was suggested to me by Rik to just remove them since there is no released binary through Debian or Ubuntu yet and since my C++ isn't great, so it was difficult to judge. For example, regarding the latter, it appears to be a public member in a public header but may (?) be used in a private instance. I'm not sure.
-- 
Your team Kubuntu Packagers is requested to review the proposed merge of ~wxl/kubuntu-packaging/+git/kdiagram:kubuntu_unstable into ~kubuntu-packagers/kubuntu-packaging/+git/kdiagram:kubuntu_unstable.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4743 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20161208/8366f288/attachment.diff>


More information about the kubuntu-devel mailing list