[Merge] ~panfaust/kubuntu-packaging/+git/akonadi:work into ~kubuntu-packagers/kubuntu-packaging/+git/akonadi:kubuntu_yakkety_archive

[Jose Manuel Santamaria Lema]

Jose Manuel Santamaria Lema has proposed merging ~panfaust/kubuntu-packaging/+git/akonadi:work into ~kubuntu-packagers/kubuntu-packaging/+git/akonadi:kubuntu_yakkety_archive.

Requested reviews:
  Kubuntu Packagers (kubuntu-packagers)

For more details, see:
https://code.launchpad.net/~panfaust/kubuntu-packaging/+git/akonadi/+merge/303187

This merge request contains 2 commits. The second commit is just fixing the format of the latest changelog entry.

The first commit re-introduces the -bin depend injection by libkf5akonadicore5 symbols file; this was removed in kubuntu to avoid circular dependencies, however that's not the correct solution.

They tried to fix the circular dependencies in debian here:
https://anonscm.debian.org/git/pkg-kde/applications/akonadi.git/commit/?id=95455706d6f2fc7538651f48b95afaa1581278c8
That's not the correct solution either. It moves the -bin dependency injection to other symbols file, so I have the impression that they weren't able to figure this out properly and they applied that wrong solution because they didn't find other way to do it.

The correct solution is adding something like this to the rules file:
lib_packages = $(filter lib%,$(shell dh_listpackages))
override_dh_shlibdeps:
        $(overridden_command) $(foreach p,$(lib_packages),-p$(p)) -- -xkdepimlibs-data -xlibkf5akonadicore-bin
        $(overridden_command) --remaining-packages -- -xkdepimlibs-data

This way we don't have circular dependencies and we can keep the -bin depend injection in the libkf5akonadicore5 symbols file, which is where it should be.
-- 
Your team Kubuntu Packagers is requested to review the proposed merge of ~panfaust/kubuntu-packaging/+git/akonadi:work into ~kubuntu-packagers/kubuntu-packaging/+git/akonadi:kubuntu_yakkety_archive.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3524 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20160817/ac0abd21/attachment-0001.diff>