Review Request 122165: install releasechecker to libmuon's data dir

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122165/#review74386
-----------------------------------------------------------



libmuon/backends/ApplicationBackend/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122165/#comment51608>

    Maybe you want to install it in libmuon/applicationsbackend or something?


- Aleix Pol Gonzalez


On Jan. 20, 2015, 10:12 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122165/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 10:12 a.m.)
> 
> 
> Review request for Kubuntu and Muon Package Management Suite.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> releasechecker originally (years ago) was part of the notifier and the
> notifier only (back then there was not even a libmuon mind you). since then
> the release checking moved into libmuon and libmuonapt, the releasechecker
> script however remained in the notifier path.
> at this point this is severely misleading for packagers and also just very
> wrong.
> 
> move the script from the notifier to the libmuon data directory to reflect
> that it belongs and is used by the libraries
> 
> 
> Diffs
> -----
> 
>   libmuon/backends/ApplicationBackend/ApplicationNotifier.cpp 3920030c2cc081ae55dc144be57cad05522c53aa 
>   libmuon/backends/ApplicationBackend/CMakeLists.txt 441e2511b36aa74e6c42aac3f681f227e2b5cefb 
>   libmuonapt/QAptActions.cpp 28d1fbf0f3482578645b78a6e74279ab25da048c 
> 
> Diff: https://git.reviewboard.kde.org/r/122165/diff/
> 
> 
> Testing
> -------
> 
> make & make install = all good
> 
> upon running muon-updater the releasechecker continues to get run.
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150120/cf2a5d5b/attachment.html>