Review Request 121730: implement proper multi-arch dependency resolution
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Jan 15 14:19:28 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121730/#review74079
-----------------------------------------------------------
utils/qapt-deb-installer/DebInstaller.cpp
<https://git.reviewboard.kde.org/r/121730/#comment51441>
Maybe it could go into a separate function?
utils/qapt-deb-installer/DebInstaller.cpp
<https://git.reviewboard.kde.org/r/121730/#comment51439>
Can you at least break this switch (or the whole loop) into a smaller separate function?
utils/qapt-deb-installer/DebInstaller.cpp
<https://git.reviewboard.kde.org/r/121730/#comment51440>
qWarning()?
- Aleix Pol Gonzalez
On Dec. 29, 2014, 7:58 p.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121730/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2014, 7:58 p.m.)
>
>
> Review request for Kubuntu, LibQApt, Aleix Pol Gonzalez, and Michael Stemle.
>
>
> Bugs: 330446, 330449, 330450, and 330451
> http://bugs.kde.org/show_bug.cgi?id=330446
> http://bugs.kde.org/show_bug.cgi?id=330449
> http://bugs.kde.org/show_bug.cgi?id=330450
> http://bugs.kde.org/show_bug.cgi?id=330451
>
>
> Repository: libqapt
>
>
> Description
> -------
>
> implement proper multi-arch dependency resolution
>
> using an exciting amount of spaghetti!
>
> BUG: 330451
> BUG: 330450
> BUG: 330449
> BUG: 330446
>
>
> Diffs
> -----
>
> src/dependencyinfo.h 14a6b635214cda032866345998af2518975b5400
> src/dependencyinfo.cpp 9e58054a92cf96f6ba80f89626b0bc5dd075411a
> utils/qapt-deb-installer/DebInstaller.h 8cb1197291741a31f2cee289a0845918006d86b2
> utils/qapt-deb-installer/DebInstaller.cpp f6b46f2b3c2d5468c7f763d5615f1e36cb292b93
>
> Diff: https://git.reviewboard.kde.org/r/121730/diff/
>
>
> Testing
> -------
>
> all test cases outlined in the bug reports
>
> I am not sure existing functionality regressed, it's all a bit nasty and the lack of apt-mocing for autottesting doesn't help the cause :/
>
>
> Thanks,
>
> Harald Sitter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150115/627d9f07/attachment.html>
More information about the kubuntu-devel
mailing list