Review Request 122033: make muon-exporter build a cmake option and disable it by default

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jan 13 13:55:05 UTC 2015



> On Jan. 13, 2015, 1:12 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 7
> > <https://git.reviewboard.kde.org/r/122033/diff/2/?file=341525#file341525line7>
> >
> >     INSTALL_MUON_EXPORTER?
> 
> Harald Sitter wrote:
>     Is that established practise somewhere?
>     
>     In phonon I always used the name as prefix as then all related plunder is sorted within CMakeCache/cmake-gui.

Well, it sounds better to me, MUON_INSTALL_EXPORTER sounds weird. But maybe it's just me. I'll drop the issue because I don't want this to block anyway.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122033/#review73936
-----------------------------------------------------------


On Jan. 13, 2015, 12:20 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122033/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 12:20 p.m.)
> 
> 
> Review request for Kubuntu and Muon Package Management Suite.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> exporter is only useful for development, so it doesn't need to be built by
> default
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2f46fb5cb792007d382125af3e8d774b41378125 
>   exporter/CMakeLists.txt 4d6c70154aa5112fa564157c9b106d64045ab4ff 
> 
> Diff: https://git.reviewboard.kde.org/r/122033/diff/
> 
> 
> Testing
> -------
> 
> make
> make install
> exporter not installed nor built
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150113/abe85c33/attachment.html>


More information about the kubuntu-devel mailing list