[Merge request] Make qapt based on qt5 buildable in sid[uction]

[Harald Sitter]

On Mon, Feb 16, 2015 at 6:12 PM, Dmitry Shachnev <mitya57 at gmail.com> wrote:
> On Wed, 11 Feb 2015 19:05:16 +0100, José Manuel Santamaría Lema wrote:
>> Also once you set the correct version for pkg-kde-tools the package building
>> still fails (partial build log attached) I think this second FTBFS is fixed
>> build depending on qt5-default.
>
> The correct fix for this is exporting QT_SELECT=qt5 in debian/rules.
>
> Please try the latest code in kubuntu_unstable branch.

That also sounds like a workaround :P

Now since I haven't looked into qtchooser for a while I'll just claim
that it not finding an lconvert at all is a bug in qtchooser (assuming
one is installed).

Arguably however the problem could also be considered to be in
extra-cmake-modules and/or pkg-kde-tools. A quick look at Qt5config
and ECM suggests that Qt5 does offer a target for the binary
> add_executable(Qt5::lconvert IMPORTED)
but ECM doesn't actually use it and instead probably calls
bin/lconvert such that qtchooser gets an opportunity to show off how
useless it is
> grep -r Qt5::lconvert /usr/share/ECM
> /usr/share/ECM/modules/ECMPoQmTools.cmake:    # This gives us Qt5::lrelease but unfortunately no Qt5::lconvert See
> /usr/share/ECM/modules/ECMCreateQmFromPoFiles.cmake:    # This gives us Qt5::lrelease and Qt5::lupdate but unfortunately no Qt5::lconvert

Perhaps the most accurate fix here indeed would be to fix ECM to not
look for the binary but use what Qt defines, which in this case would
be
> ./Qt5LinguistTools/Qt5LinguistToolsConfig.cmake:    set(imported_location "${_qt5_linguisttools_install_prefix}/lib/x86_64-linux-gnu/qt5/bin/lconvert")
which should be a good enough path one presumes.

HS