Review Request 126490: port away from KDELibs4Support

[Carlo Vanini]

> On Dec. 23, 2015, 5:30 p.m., Aleix Pol Gonzalez wrote:
> > Good start!
> > 
> > Ship it, given you made sure it works. :)
> > 
> > (do you have a developer account? Otherwise I'll push it for you)

I tried it on Kubuntu 15.10 with KF 5.15.0 and Qt 5.4.2.
It works (I tried upgrading packages) with no apparent change on the visual layout.

The Changelog tab is working again. Before the download of the changelog file did fail.

Please, push it for me.


- Carlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126490/#review90011
-----------------------------------------------------------


On Dec. 23, 2015, 5:16 p.m., Carlo Vanini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126490/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 5:16 p.m.)
> 
> 
> Review request for Kubuntu and Muon Package Management Suite.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> This removes the dependency from KDELibs4Support.
> 
> Added KF5 dependecies are I18n, IconThemes and XmlGui.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5c232f66fa38ebe09a663ede5094691d9b77d746 
>   src/CMakeLists.txt b321bb1e04ba6da485cb3ff86afddd7846d0edca 
>   src/DetailsTabs/ChangelogTab.h 10d40b6db409cdb280f7c89fded57989ea4a2ddc 
>   src/DetailsTabs/ChangelogTab.cpp 11daafd4cc088e11f4581fbd7d2fdc0eb22bc117 
>   src/DetailsTabs/DependsTab.h eb5432f9eaeb51e057a2e7eb71c13eac95095be4 
>   src/DetailsTabs/DependsTab.cpp b83a6436748b5eb27d691b8f2b1d54cb5cd96441 
>   src/DetailsTabs/InstalledFilesTab.h 8a5bfe4c16492b70c6bccf86892eec179d5b26c3 
>   src/DetailsTabs/InstalledFilesTab.cpp cf110d9cf5a4a408b3a73faa78341363cdbf14a5 
>   src/DetailsTabs/MainTab.h f9aa9a6daeee22058eee87af0a40426d6dc7cabc 
>   src/DetailsTabs/MainTab.cpp b20d7c76d6ca5e0f555fc4313b0c4e6a481c263b 
>   src/DetailsTabs/TechnicalDetailsTab.cpp e387cb8d4afeba6b2b8f8cad7c5ffe0927f064fc 
>   src/DetailsTabs/VersionTab.cpp f3a903f584b5e0eb49793950a953ffd08aae9698 
>   src/DetailsWidget.h 80f7a9aa3733d9b48272222e8bf16b469001025d 
>   src/DetailsWidget.cpp f3b95d9bad0810c8f32744ddb8cd868e0c34a8b5 
>   src/DownloadModel/DownloadDelegate.cpp 4cf01aeee5bdd98ca3591fd98660be314ea17217 
>   src/DownloadModel/DownloadModel.cpp 0916ec78fe7b33eeeb6116d76d30540374e7d96b 
>   src/MainWindow.cpp de068d81579f4ed0dcf7e440cd5eb757a51790ad 
>   src/ManagerWidget.cpp 930c4afdb4bd8fae13ad25c5b57da18af8b24b92 
>   src/PackageModel/PackageView.h 89e4db3950668b0b88eaf15bcaec303ce75b7b58 
>   src/PackageModel/PackageWidget.h 7e6503b5c4b4d65039e7222c622d4599ed867911 
>   src/PackageModel/PackageWidget.cpp bf10d14889847a9de1af0438f285c6275c3c4aa9 
>   src/StatusWidget.cpp 17e11c1debfc4806fc54895aaccb5f69be83c94b 
>   src/TransactionWidget.cpp fd25646d9e86dd13032f2c5aeedb2fb421717a67 
>   src/config/GeneralSettingsPage.cpp 42d9f21df094504f081c152caf9f5e1123995769 
> 
> Diff: https://git.reviewboard.kde.org/r/126490/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carlo Vanini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20151224/b81b339f/attachment-0001.html>