Strange symbols issue.

[Scott Kitterman]

On Wednesday, December 02, 2015 05:30:06 PM Scarlett Clark wrote:
> networkmanager-qt has symbols failure. Upon batchpatch completion it wants
> me to remove a pile of symbols.
> Looking for patches and reading them ....
> ----------------------------------------------
> 
> | Processing libkf5networkmanagerqt6 package |
> 
> ----------------------------------------------
> Patching symbol file 'debian/libkf5networkmanagerqt6.symbols' with supplied
> patches ...
> * patch 'libkf5networkmanagerqt6_5.16.0+git20151202.2238+16.04-0_amd64 (---
> debian/libkf5networkmanagerqt6.symbols)' for amd64 ... OK.
> Confirmed arches: alpha, arm64, armel, armhf, hppa, i386, mips, mips64el,
> mipsel, powerpc, ppc64, ppc64el, s390x, x32
> Generating symbol file template .... (this might take a while)
> pkgkde-symbolshelper: warning: there are LOST symbols (including optional):
>  SONAME: libKF5NetworkManagerQt.so.6
>   #MISSING: 5.16.0# _ZN14NetworkManager11AccessPoint15lastSeenChangedEi at Base
> 5.14.0
>   #MISSING: 5.16.0#
> _ZN14NetworkManager6Device14meteredChangedENS0_13MeteredStatusE at Base 5.14.0
>   #MISSING: 5.16.0# _ZN14NetworkManager7meteredEv at Base 5.14.0
>   #MISSING: 5.16.0#
> _ZN14NetworkManager8Notifier14meteredChangedENS_6Device13MeteredStatusE at Base
> 5.14.0
>   #MISSING: 5.16.0# _ZNK14NetworkManager11AccessPoint8lastSeenEv at Base 5.14.0
> #MISSING: 5.16.0# _ZNK14NetworkManager6Device7meteredEv at Base 5.14.0
> scarlett at scarlett-lappy:~/Work/xenial-frameworks/networkmanager-qt$ c++filt
> _ZN14NetworkManager11AccessPoint15lastSeenChangedEi
> NetworkManager::AccessPoint::lastSeenChanged(int)
> scarlett at scarlett-lappy:~/Work/xenial-frameworks/networkmanager-qt$ c++filt
> _ZN14NetworkManager6Device14meteredChangedENS0_13MeteredStatusE
> NetworkManager::Device::meteredChanged(NetworkManager::Device::MeteredStatus
> )
> 
> Upon looking up these symbols they all where created in this RR:
> https://git.reviewboard.kde.org/r/124998/diff/1-2/
> 
> Looking through all commits since, I see no where that these were removed.
> Could someone please educate me and tell me why they would suddenly vanish
> from our build. My gut feeling tells me that removing these would end badly.
> Thank you,
> Scarlett

Looking at the Debian upload for 5.16, Maxy didn't make any symbols changes 
[1] and it looks like that was correct as the build log doesn't show any 
changes found during the actual package build [2].  I see you've packaged a 
git snapshot rather than the actual 5.16 release, but there's only one commit 
past 5.16 and it adds code with no deletions [3].  Based on that, I agree 
there shouldn't be lost symbols.

Here's a few things to check:

1.  Make sure the git snapshot you're using as an the upstream source is 
correct/complete.  You might also try building the 5.16 release tarball and 
see if you get a different result.

2.  Redo the build and see if you get the same result.

3.  Check and see if maybe batchpatch didn't add the symbols back in somewhere 
else.

4.  This is a long shot, but Debian in on network-manager 1.0.8 and Ubuntu 
still have 1.0.4.  I've no idea how that could matter, but who knows.

Scott K



[1] http://anonscm.debian.org/cgit/pkg-kde/frameworks/networkmanager-qt.git/
[2] https://buildd.debian.org/status/fetch.php?pkg=networkmanager-qt&arch=amd64&ver=5.16.0-1&stamp=1448893047
[3] https://projects.kde.org/projects/frameworks/networkmanager-qt/repository/