Review Request 125003: Use kdesu instead of pkexec

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125003/#review84652
-----------------------------------------------------------


With kdesu you need to either separate the actual calls with "--", or -c followed by a completely built argument string

e.g.
/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu -- /usr/bin/software-properties-kde --attach 23068678 --dont-update
OR
/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu -c "/usr/bin/software-properties-kde --attach 23068678 --dont-update"

any other argument list will result in kdesu parsing --attach and --dont-update as kdesu arguments.

Also argument spearation for --attach is broken.

I Opened issues for all of that


libmuonapt/QAptActions.cpp (line 392)
<https://git.reviewboard.kde.org/r/125003/#comment58585>

    needs -- or -c for argument list



libmuonapt/QAptActions.cpp (line 395)
<https://git.reviewboard.kde.org/r/125003/#comment58584>

    should be "--attach" << winid
    i.e. winid as additional argument not concated onto --attach
    
    currently this comes out as 
    
    23529 execve("/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu", ["/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu", "/usr/bin/software-properties-kde", "--attach23068678", "--dont-update"], [/* 112 vars */] <unfinished ...>



libmuonapt/QAptActions.cpp (line 506)
<https://git.reviewboard.kde.org/r/125003/#comment58586>

    needs -- or -c for argument list


- Harald Sitter


On Aug. 31, 2015, 2:17 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125003/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 2:17 p.m.)
> 
> 
> Review request for Kubuntu, Muon Package Management Suite and Harald Sitter.
> 
> 
> Bugs: 351311
>     http://bugs.kde.org/show_bug.cgi?id=351311
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> pkexec doesn't cut it on GUI applications, kdesu seems to work.
> 
> On kubuntu it should be using sudo instead of su.
> 
> 
> Diffs
> -----
> 
>   README.PACKAGERS 28f1519 
>   libmuon/backends/ApplicationBackend/ApplicationNotifier.cpp bb56c35 
>   libmuon/backends/ApplicationBackend/CMakeLists.txt 4785e1f 
>   libmuonapt/CMakeLists.txt 1c8bae9 
>   libmuonapt/QAptActions.cpp 7b82f67 
> 
> Diff: https://git.reviewboard.kde.org/r/125003/diff/
> 
> 
> Testing
> -------
> 
> Builds, coudln't test further.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150831/2364dccc/attachment-0001.html>