Review Request 119791: Fix Regexp to match new upstart version output
Harald Sitter
sitter at kde.org
Sun Sep 7 14:16:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119791/#review65992
-----------------------------------------------------------
Ship it!
Ship It!
- Harald Sitter
On Sept. 7, 2014, 1 p.m., Philip Muskovac wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119791/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2014, 1 p.m.)
>
>
> Review request for Kubuntu and Plasma.
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> So upstart likes to give people headaches and changed how it prints the version over dbus:
>
> $ qdbus com.ubuntu.Upstart /com/ubuntu/Upstart com.ubuntu.Upstart0_6.version
> init (upstart 1.12.1)
>
> vs.
>
> $ qdbus com.ubuntu.Upstart /com/ubuntu/Upstart com.ubuntu.Upstart0_6.version
> upstart 1.13.1
>
> so now the regexp in the powerdevil version check doesn't match anymore. Fixed by making init and brackets optional
>
>
> Diffs
> -----
>
> daemon/backends/upower/powerdevilupowerbackend.cpp 6b7c650
>
> Diff: https://git.reviewboard.kde.org/r/119791/diff/
>
>
> Testing
> -------
>
> "(?:init \()?upstart ([0-9.]+)(?:\))?" matches both "upstart 1.13.1" and "init (upstart 1.12.1)"
>
>
> Thanks,
>
> Philip Muskovac
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20140907/05b06bca/attachment.html>
More information about the kubuntu-devel
mailing list